docs(agentmesh-avp): document did:key-only limitation#1315
Merged
imran-siddique merged 1 commit intomicrosoft:mainfrom Apr 22, 2026
Merged
Conversation
Per review feedback on microsoft#1010 — the agentmesh-avp provider only accepts did:key identifiers. Other DID methods (did:web, did:ion, etc.) are rejected by the DID format validator in provider.py. Also documents the score-threshold fallback behavior when the AVP verification endpoint is unreachable.
20 tasks
Contributor
|
Have two PR's open to fix the failures of the link and spell check as soon as they are approved and fixed we can kick this off again |
imran-siddique
approved these changes
Apr 22, 2026
imran-siddique
pushed a commit
to imran-siddique/agent-governance-toolkit
that referenced
this pull request
May 4, 2026
Per review feedback on microsoft#1010 — the agentmesh-avp provider only accepts did:key identifiers. Other DID methods (did:web, did:ion, etc.) are rejected by the DID format validator in provider.py. Also documents the score-threshold fallback behavior when the AVP verification endpoint is unreachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to merged #1010. Documents two known behaviors of the
agentmesh-avpprovider that aren't immediately obvious from the API surface:did:keyidentifiers are accepted. Other methods (did:web,did:ion, etc.) are rejected by the format validator inprovider.py(_DID_PATTERN = r"^did:key:z6Mk[1-9A-HJ-NP-Za-km-z]{43,}$").verify_identityfalls back to score-based verification usingmin_score_thresholdwhen the AVP endpoint is unreachable, and logs a warning.No code changes — adds a
## Limitationssection topackages/agentmesh-integrations/agentmesh-avp/README.md(5 lines).Context
did:keyvalidation, not agent-mesh internal DID format.docs/avp-did-key-limitationlocal branch referenced in review comments on feat(agentmesh-avp): add AVPProvider for EigenTrust reputation scoring #1010.Test plan
_DID_PATTERNon currentmainstill constrains todid:key:z6Mk…provider.pylogic