Skip to content

docs(agentmesh-avp): document did:key-only limitation#1315

Merged
imran-siddique merged 1 commit intomicrosoft:mainfrom
creatorrmode-lead:pr2/agentmesh-avp-did-key-docs
Apr 22, 2026
Merged

docs(agentmesh-avp): document did:key-only limitation#1315
imran-siddique merged 1 commit intomicrosoft:mainfrom
creatorrmode-lead:pr2/agentmesh-avp-did-key-docs

Conversation

@creatorrmode-lead
Copy link
Copy Markdown
Contributor

Summary

Follow-up to merged #1010. Documents two known behaviors of the agentmesh-avp provider that aren't immediately obvious from the API surface:

  • DID method scope: only did:key identifiers are accepted. Other methods (did:web, did:ion, etc.) are rejected by the format validator in provider.py (_DID_PATTERN = r"^did:key:z6Mk[1-9A-HJ-NP-Za-km-z]{43,}$").
  • Fallback behavior: verify_identity falls back to score-based verification using min_score_threshold when the AVP endpoint is unreachable, and logs a warning.

No code changes — adds a ## Limitations section to packages/agentmesh-integrations/agentmesh-avp/README.md (5 lines).

Context

Test plan

  • Verified _DID_PATTERN on current main still constrains to did:key:z6Mk…
  • Verified fallback behavior matches current provider.py logic
  • No runtime/test surface to exercise — docs-only

Per review feedback on microsoft#1010 — the agentmesh-avp provider only accepts
did:key identifiers. Other DID methods (did:web, did:ion, etc.) are
rejected by the DID format validator in provider.py.

Also documents the score-threshold fallback behavior when the AVP
verification endpoint is unreachable.
@github-actions github-actions Bot added documentation Improvements or additions to documentation size/XS Extra small PR (< 10 lines) labels Apr 22, 2026
@Ricky-G
Copy link
Copy Markdown
Contributor

Ricky-G commented Apr 22, 2026

Have two PR's open to fix the failures of the link and spell check as soon as they are approved and fixed we can kick this off again

@imran-siddique imran-siddique enabled auto-merge (squash) April 22, 2026 13:21
@imran-siddique imran-siddique merged commit 0c6be3c into microsoft:main Apr 22, 2026
36 of 39 checks passed
imran-siddique pushed a commit to imran-siddique/agent-governance-toolkit that referenced this pull request May 4, 2026
Per review feedback on microsoft#1010 — the agentmesh-avp provider only accepts
did:key identifiers. Other DID methods (did:web, did:ion, etc.) are
rejected by the DID format validator in provider.py.

Also documents the score-threshold fallback behavior when the AVP
verification endpoint is unreachable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS Extra small PR (< 10 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants