Commit e5a272a
fix(install): strip non-ASCII bytes from install.ps1 (#1523)
Follow-up to this PR's first commit. The Windows CI 'apm self-update'
test (Test 5) downloads install.ps1 via Python urllib in the v0.13.0
installed CLI and prints it through a cp1252 console; the script
must therefore be pure ASCII or the print raises
'charmap codec can't encode characters in position 33941-33942'.
Two violations of the repo's ASCII-only rule
(.github/instructions/encoding.instructions.md):
1. Em-dash (U+2014) in a pre-existing comment at byte 29170
('need a retry -- acceptable for an install/self-update').
Replaced with the ASCII '--' digraph.
2. Replacement characters (U+FFFD U+FFFD) at byte 33139 inside the
comment this PR just added describing what a UTF-16 cmd.exe parse
failure looks like. I had literally pasted the garbled-output
illustration verbatim. Reworded to describe the failure mode in
plain ASCII prose.
install.ps1 now contains zero bytes above 0x7E. The previously-failing
self-update path can write the script to a cp1252 console without
raising UnicodeEncodeError.
Co-authored-by: danielmeppiel <danielmeppiel@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 61917d6 commit e5a272a
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
729 | 729 | | |
730 | 730 | | |
731 | 731 | | |
732 | | - | |
| 732 | + | |
733 | 733 | | |
734 | 734 | | |
735 | 735 | | |
| |||
802 | 802 | | |
803 | 803 | | |
804 | 804 | | |
805 | | - | |
| 805 | + | |
| 806 | + | |
806 | 807 | | |
807 | 808 | | |
808 | 809 | | |
| |||
0 commit comments