Skip to content

Commit bdf78de

Browse files
committed
Aligning icons, text, action buttons to be on the same level
1 parent 06fdfb7 commit bdf78de

6 files changed

Lines changed: 53 additions & 26 deletions

File tree

css/src/components/banner.scss

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
1+
$banner-min-height: 50px !default;
12
$banner-background: $secondary-background !default;
23
$banner-padding-block: 0.75em !default;
34

45
$banner-gap: $spacer-3 !default;
5-
$banner-icon-block-spacing: 0.2em !default;
6+
7+
$banner-icon-size: 1.145em !default;
8+
$banner-icon-block-spacing: 0.35em !default;
9+
10+
$banner-content-block-spacing: 0.3em !default;
611

712
$banner-color: $text !default;
813
$banner-font-size: $font-size-8 !default;
@@ -18,6 +23,7 @@ $banner-border-width: $border-width !default;
1823
display: grid;
1924
position: relative;
2025
align-items: flex-start;
26+
min-height: $banner-min-height;
2127
outline-color: $text;
2228
background-color: $banner-background;
2329
color: $banner-color;
@@ -60,9 +66,10 @@ $banner-border-width: $border-width !default;
6066
@include loader;
6167

6268
position: absolute;
63-
inset-block-start: $banner-padding-block;
64-
inset-inline-start: $layout-gap;
6569
border-color: transparent transparent $banner-color $banner-color;
70+
font-size: $banner-icon-size;
71+
inset-block-start: calc($banner-padding-block + $banner-icon-block-spacing);
72+
inset-inline-start: $layout-gap;
6673

6774
@include widescreen {
6875
inset-inline-start: $layout-widescreen-gap;
@@ -92,12 +99,18 @@ $banner-border-width: $border-width !default;
9299

93100
p {
94101
max-width: $reading-max-width;
102+
103+
&:first-child {
104+
margin-block-start: $banner-content-block-spacing;
105+
}
95106
}
96107
}
97108

98109
.banner-icon {
99-
grid-area: icon;
100110
flex-shrink: 0;
111+
font-size: $banner-icon-size;
112+
line-height: 1;
113+
grid-area: icon;
101114
margin-inline-end: $banner-gap;
102115
}
103116

css/src/components/notification.scss

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1+
$notification-min-height: 50px !default;
12
$notification-background: $secondary-background !default;
23
$notification-padding-block: 0.75em !default;
34
$notification-padding-inline: 0.85em !default;
4-
55
$notification-gap: $spacer-3 !default;
6-
$notification-icon-block-spacing: 0.2em !default;
6+
7+
$notification-icon-size: 1.145em !default;
8+
$notification-icon-block-spacing: 0.35em !default;
9+
10+
$notification-content-block-spacing: 0.3em !default;
711

812
$notification-color: $text !default;
913
$notification-font-size: $font-size-8 !default;
@@ -18,6 +22,7 @@ $notification-border-radius: $border-radius !default;
1822
display: grid;
1923
position: relative;
2024
align-items: flex-start;
25+
min-height: $notification-min-height;
2126
border: $notification-border-width solid $notification-border-color;
2227
border-radius: $notification-border-radius;
2328
outline-color: $text;
@@ -62,9 +67,10 @@ $notification-border-radius: $border-radius !default;
6267
@include loader;
6368

6469
position: absolute;
65-
inset-block-start: $notification-padding-block;
66-
inset-inline-start: $notification-padding-inline;
6770
border-color: transparent transparent $notification-color $notification-color;
71+
font-size: $notification-icon-size;
72+
inset-block-start: calc($notification-padding-block + $notification-icon-block-spacing);
73+
inset-inline-start: $notification-padding-inline;
6874
}
6975
}
7076

@@ -76,6 +82,10 @@ $notification-border-radius: $border-radius !default;
7682
margin-inline-end: $notification-gap;
7783
}
7884

85+
p:first-child {
86+
margin-block-start: $notification-content-block-spacing;
87+
}
88+
7989
a:not(.button) {
8090
text-decoration: underline;
8191

@@ -90,8 +100,10 @@ $notification-border-radius: $border-radius !default;
90100
}
91101

92102
.notification-icon {
93-
grid-area: icon;
94103
flex-shrink: 0;
104+
font-size: $notification-icon-size;
105+
line-height: 1;
106+
grid-area: icon;
95107
margin-inline-end: $notification-gap;
96108
}
97109

0 commit comments

Comments
 (0)