Skip to content

[FEATURE] Option to emit group chat manager messages in AgentChat #6303

Merged
ekzhu merged 11 commits into
microsoft:mainfrom
SongChiYoung:Refactor/issue-6161-clean-approach
Apr 16, 2025
Merged

[FEATURE] Option to emit group chat manager messages in AgentChat #6303
ekzhu merged 11 commits into
microsoft:mainfrom
SongChiYoung:Refactor/issue-6161-clean-approach

Conversation

@SongChiYoung
Copy link
Copy Markdown
Contributor

@SongChiYoung SongChiYoung commented Apr 15, 2025

Why are these changes needed?

Add an option emit_team_events to BaseGroupChat to emit events from group chat manager through run_stream.
SpeakerSelectedEvent from group chat speaker selection.

Related issue number

Closes #6161

Checks

@SongChiYoung
Copy link
Copy Markdown
Contributor Author

@ekzhu
This PR adds support for emitting SpeakerSelectedEvent during group chat speaker selection.

I'm wondering if you'd like this to be extended to emit other internal team events as well.
Are there any specific types of events you'd want to be exposed at this level?

Copy link
Copy Markdown
Contributor

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good let's start with this.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.49%. Comparing base (a4a16fd) to head (d86a01c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...p_chat/_magentic_one/_magentic_one_orchestrator.py 25.00% 3 Missing ⚠️
...utogen-agentchat/src/autogen_agentchat/messages.py 85.71% 1 Missing ⚠️
...chat/teams/_group_chat/_base_group_chat_manager.py 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6303      +/-   ##
==========================================
+ Coverage   77.48%   77.49%   +0.01%     
==========================================
  Files         202      202              
  Lines       14717    14742      +25     
==========================================
+ Hits        11403    11424      +21     
- Misses       3314     3318       +4     
Flag Coverage Δ
unittests 77.49% <90.19%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SongChiYoung
Copy link
Copy Markdown
Contributor Author

Hey @ekzhu,

I just saw the changes you pushed — the added unit tests, improved comments, and other refinements… I really appreciate the extra effort you put in. 🙏

Honestly, I feel a bit bad for not catching those things myself — I’m still learning and trying to get better at writing more polished PRs from the start. Your improvements are super helpful, and I’m grateful for the care you put into them.

Thanks again — I’ll keep iterating and do my best to make your review experience smoother next time.

@ekzhu ekzhu merged commit 844de21 into microsoft:main Apr 16, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to emit group chat manager messages in AgentChat

2 participants