[FEATURE] Option to emit group chat manager messages in AgentChat #6303
Conversation
|
@ekzhu I'm wondering if you'd like this to be extended to emit other internal team events as well. |
ekzhu
left a comment
There was a problem hiding this comment.
Looks good let's start with this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6303 +/- ##
==========================================
+ Coverage 77.48% 77.49% +0.01%
==========================================
Files 202 202
Lines 14717 14742 +25
==========================================
+ Hits 11403 11424 +21
- Misses 3314 3318 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @ekzhu, I just saw the changes you pushed — the added unit tests, improved comments, and other refinements… I really appreciate the extra effort you put in. 🙏 Honestly, I feel a bit bad for not catching those things myself — I’m still learning and trying to get better at writing more polished PRs from the start. Your improvements are super helpful, and I’m grateful for the care you put into them. Thanks again — I’ll keep iterating and do my best to make your review experience smoother next time. |
Why are these changes needed?
Add an option emit_team_events to BaseGroupChat to emit events from group chat manager through run_stream.
SpeakerSelectedEvent from group chat speaker selection.
Related issue number
Closes #6161
Checks