Skip to content

Avoid re-registering a message type already registered#6354

Merged
ekzhu merged 6 commits into
microsoft:mainfrom
jorge-wonolo:avoid-over-registering-structure-messages
Apr 22, 2025
Merged

Avoid re-registering a message type already registered#6354
ekzhu merged 6 commits into
microsoft:mainfrom
jorge-wonolo:avoid-over-registering-structure-messages

Conversation

@jorge-wonolo
Copy link
Copy Markdown
Contributor

Why are these changes needed?

This change avoid re-registering a structured message already registered to the team by a previous agent also included in the team.

This issue occurs when agents share Pydantic models as output format

Related issue number

Closes #6353

Checks

@ekzhu ekzhu enabled auto-merge (squash) April 22, 2025 00:15
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.99%. Comparing base (0015315) to head (b9b8a44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6354   +/-   ##
=======================================
  Coverage   77.99%   77.99%           
=======================================
  Files         214      214           
  Lines       15383    15384    +1     
=======================================
+ Hits        11998    11999    +1     
  Misses       3385     3385           
Flag Coverage Δ
unittests 77.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

auto-merge was automatically disabled April 22, 2025 00:34

Head branch was pushed to by a user without write access

@jorge-wonolo
Copy link
Copy Markdown
Contributor Author

@ekzhu thanks for the review, I had to push a formatting fix

@ekzhu
Copy link
Copy Markdown
Contributor

ekzhu commented Apr 22, 2025

Looks like there is a pyright error. I think we can add a type ignore here

@jorge-wonolo
Copy link
Copy Markdown
Contributor Author

Looks like there is a pyright error. I think we can add a type ignore here

Yes added the exception

@ekzhu ekzhu merged commit f00f7d2 into microsoft:main Apr 22, 2025
60 checks passed
peterj added a commit to kagent-dev/autogen that referenced this pull request Apr 24, 2025
…e0424

* upstream/main:
  Remove `name` field from OpenAI Assistant Message (microsoft#6388)
  Introduce workbench (microsoft#6340)
  TEST/change gpt4, gpt4o serise to gpt4.1nano (microsoft#6375)
  update website version (microsoft#6364)
  Add self-debugging loop to `CodeExecutionAgent` (microsoft#6306)
  Fix: deserialize model_context in AssistantAgent and SocietyOfMindAgent and CodeExecutorAgent (microsoft#6337)
  Add azure ai agent (microsoft#6191)
  Avoid re-registering a message type already registered (microsoft#6354)
  Added support for exposing GPUs to docker code executor (microsoft#6339)
  fix: ollama fails when tools use optional args (microsoft#6343)
  Add an example using autogen-core and FastAPI to create streaming responses (microsoft#6335)
  FEAT: SelectorGroupChat could using stream inner select_prompt (microsoft#6286)
  Add experimental notice to canvas (microsoft#6349)
  DOC: add extentions - autogen-oaiapi and autogen-contextplus (microsoft#6338)
  fix: ensure serialized messages are passed to LLMStreamStartEvent (microsoft#6344)
  Generalize Continuous SystemMessage merging via model_info[“multiple_system_messages”] instead of `startswith("gemini-")` (microsoft#6345)
  Agentchat canvas (microsoft#6215)

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Teams with agents that contain duplicated produced_message_types result in an ValueError exception

2 participants