Fix: Catch TargetClosedError in PlaywrightController.sleep() to avoid crashes on download-triggered page closes#6415
Open
oscarvdl wants to merge 4 commits into
Conversation
… crashes on download-triggered page closes.
ekzhu
approved these changes
May 6, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6415 +/- ##
==========================================
- Coverage 79.52% 79.51% -0.01%
==========================================
Files 225 225
Lines 16624 16627 +3
==========================================
+ Hits 13220 13221 +1
- Misses 3404 3406 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes a crash that occurs when using
MultimodalWebSurferin scenarios where a click triggers a file download.After the download is initiated, Playwright may close the page or context, leading to a
TargetClosedErrorduringsleep()inPlaywrightController.The previous implementation of
sleep()did not handle these closures, causing the agent to crash unexpectedly.This PR adds safe exception handling for
TargetClosedErrorandPlaywrightErrorduringsleep(), ensuring that the agent can continue operating gracefully even if the page closes.Related issue number
Closes #6413
Checks