security: fix SSRF in AutoGen Studio fetch_webpage tool#7706
Open
hoangperry wants to merge 1 commit into
Open
Conversation
fetch_webpage() called httpx.get(url) with follow_redirects=True and no URL validation, allowing requests to private/internal network addresses when the tool is used in a server-side agent deployment. Changes: - Add _validate_url() that resolves hostname to IP and blocks RFC 1918, loopback, and link-local ranges (including cloud metadata endpoints). - Switch to follow_redirects=False and validate each redirect target before following, preventing redirect-chain bypass.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_webpage()inautogenstudio/gallery/tools/fetch_webpage.pycallshttpx.get(url)with no URL validation andfollow_redirects=True(httpx default). When deployed as a server-side agent, this allows any agent user to cause the server to fetch internal network addresses.Vulnerable code (before)
No IP range check.
follow_redirects=Truemeans an attacker-controlled server returning 302 to an internal address bypasses future URL-based filtering.Fix
_validate_url(): resolves hostname to IP and blocks RFC 1918, loopback, and link-local (169.254.x.x) ranges before making any request.follow_redirects=Falseand validate each redirect target before following.Test plan
http://127.0.0.1/→ ValueError (loopback)http://169.254.169.254/→ ValueError (cloud metadata)http://10.0.0.1/→ ValueError (RFC 1918)