fix: add encoding=utf-8 to open() calls in task_centric_memory utils#7897
Open
Lakshmi786 wants to merge 1 commit into
Open
fix: add encoding=utf-8 to open() calls in task_centric_memory utils#7897Lakshmi786 wants to merge 1 commit into
Lakshmi786 wants to merge 1 commit into
Conversation
Text-mode open() without an explicit encoding falls back to the platform locale, which is not UTF-8 on Windows with non-English system locales. This causes UnicodeDecodeError / UnicodeEncodeError when session files or log HTML pages contain non-ASCII characters. Affected files: - chat_completion_client_recorder.py (read + write of JSON session) - page_logger.py (write of hash.txt, call-tree HTML, page HTML) Closes microsoft#5566
Author
|
Hi, Fixing issue #5566. Text-mode open() calls without an explicit encoding fall back to the platform locale, which is not UTF-8 on Windows with non-English system locales. This causes UnicodeDecodeError or UnicodeEncodeError when session files or HTML log pages contain non-ASCII content. Fixed five open() calls across two files in task_centric_memory:
The playwright_controller.py file was already correctly using encoding=utf-8. |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Text-mode
open()calls without an explicit encoding fall back to the platform locale, which is not UTF-8 on Windows with non-English system locales. This causesUnicodeDecodeError/UnicodeEncodeErrorwhen session files or HTML log pages contain non-ASCII characters.Files fixed
chat_completion_client_recorder.py— read + write of JSON session filepage_logger.py— write ofhash.txt, call-tree HTML, and page HTMLFixes #5566