fix(agentchat): remove dead typo attribute in CodeExecutorAgent#7914
Open
nolanchic wants to merge 1 commit into
Open
fix(agentchat): remove dead typo attribute in CodeExecutorAgent#7914nolanchic wants to merge 1 commit into
nolanchic wants to merge 1 commit into
Conversation
CodeExecutorAgent.__init__ assigned self._system_messaages (note the extra 'a' in 'messaages'), which is never read anywhere. The agent actually uses self._system_messages (correctly spelled), assigned on the very next lines. The misspelled attribute is dead state created on every instantiation — remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
CodeExecutorAgent.__init__assigns a misspelled attributeself._system_messaages(note the extraain messaages) that is never read anywhere in the codebase:The agent consistently uses the correctly-spelled
self._system_messages(assigned on the very next lines, read at lines 525, 756, 757). Agrep -rn "_system_messaages"across the whole repo confirms the misspelled form appears only on this single line — it is dead state created on every instantiation.This removes the dead attribute. No behavior change.
Related issue number
N/A — trivial dead-code cleanup.
Checks
CodeExecutorAgenttests still pass.)Local verification