Fix security and correctness issues in artifacts_download#780
Merged
johnbatty merged 1 commit intoApr 25, 2026
Merged
Conversation
johnbatty
commented
Apr 19, 2026
johnbatty
commented
Collaborator
- Use path_segments_mut() for URL construction to prevent path injection
- Reject manifest entries with .. path components (path traversal)
- Normalize blob ID map keys to uppercase for consistent matching
- Batch-resolve all file root blob URLs in one request
- Simplify nibble_pos type in decompressor (bool was unused)
- Cap deserialization error previews at 512 bytes
- Guard Vec::with_capacity against i64->usize overflow
- Use path_segments_mut() for URL construction to prevent path injection - Reject manifest entries with .. path components (path traversal) - Normalize blob ID map keys to uppercase for consistent matching - Batch-resolve all file root blob URLs in one request - Simplify nibble_pos type in decompressor (bool was unused) - Cap deserialization error previews at 512 bytes - Guard Vec::with_capacity against i64->usize overflow Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
@cataggar Please could you review these updates from Claude - all look sensible to me, but I'm not able to test them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.