Skip to content

Commit 0a42079

Browse files
committed
Comments addressed.
1 parent c665d56 commit 0a42079

3 files changed

Lines changed: 8 additions & 11 deletions

File tree

toolkit/tools/internal/targetos/targetos.go

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ type TargetOs string
1818
const (
1919
TargetOsAzureLinux2 TargetOs = "azl2"
2020
TargetOsAzureLinux3 TargetOs = "azl3"
21-
TargetOsAcl TargetOs = "acl"
21+
TargetOsAzureContainerLinux3 TargetOs = "acl3"
2222
TargetOsFedora42 TargetOs = "fedora42"
2323
TargetOsUbuntu2204 TargetOs = "ubuntu2204"
2424
TargetOsUbuntu2404 TargetOs = "ubuntu2404"
@@ -56,24 +56,21 @@ func GetInstalledTargetOs(rootfs string) (TargetOs, error) {
5656
switch variantId {
5757
case "azurecontainerlinux":
5858
// ACL uses VERSION_ID like "3.0.YYYYMMDD" (e.g. "3.0.20260421").
59-
// Accept any version that starts with "3.0".
60-
if !strings.HasPrefix(versionId, "3.0") {
59+
// Accept any version that starts with "3.0.".
60+
if !strings.HasPrefix(versionId, "3.0.") {
6161
return "", fmt.Errorf("unknown VERSION_ID (%s) for Azure Container Linux in os-release", versionId)
6262
}
63-
return TargetOsAcl, nil
63+
return TargetOsAzureContainerLinux3, nil
6464

65-
case "":
66-
// Standard Azure Linux.
65+
default:
66+
// Standard Azure Linux (or unknown variant — treat as standard).
6767
switch versionId {
6868
case "3.0":
6969
return TargetOsAzureLinux3, nil
7070

7171
default:
7272
return "", fmt.Errorf("unknown VERSION_ID (%s) for Azure Linux in os-release", versionId)
7373
}
74-
75-
default:
76-
return "", fmt.Errorf("unknown VARIANT_ID (%s) for Azure Linux in os-release", variantId)
7774
}
7875

7976
case "fedora":

toolkit/tools/pkg/imagecustomizerlib/distrohandler.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func NewDistroHandlerFromTargetOs(targetOs targetos.TargetOs) DistroHandler {
8383
return newAzureLinuxDistroHandler("2.0")
8484
case targetos.TargetOsAzureLinux3:
8585
return newAzureLinuxDistroHandler("3.0")
86-
case targetos.TargetOsAcl:
86+
case targetos.TargetOsAzureContainerLinux3:
8787
return newAclDistroHandler()
8888
case targetos.TargetOsUbuntu2204:
8989
return newUbuntuDistroHandler("22.04")

toolkit/tools/pkg/imagecustomizerlib/distrohandler_acl.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func newAclDistroHandler() *aclDistroHandler {
2727
}
2828

2929
func (d *aclDistroHandler) GetTargetOs() targetos.TargetOs {
30-
return targetos.TargetOsAcl
30+
return targetos.TargetOsAzureContainerLinux3
3131
}
3232

3333
func (d *aclDistroHandler) ValidateConfig(rc *ResolvedConfig) error {

0 commit comments

Comments
 (0)