Skip to content

Commit 956edd5

Browse files
authored
Fix: test_min_change_efi_azl4_qcow_output (on arm64) failing due to unavailable dracut-virtio (#722)
This PR fixes failing test `test_min_change_efi_azl4_qcow_output` by removing `dracut-virtio` in the relevant config. `dracut-virtio` is preinstalled on all azl3 VMs and is not needed for azl4, so we can also simplify further the number of configs needed for this class of tests.
1 parent 161fbeb commit 956edd5

7 files changed

Lines changed: 5 additions & 50 deletions

File tree

test/vmtests/vmtests/imagecustomizer/test_min_change.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,7 @@ def test_min_change_efi_azl3_qcow_output(
208208
close_list: List[Closeable],
209209
) -> None:
210210
azl_release = 3
211-
if platform.machine() == "x86_64":
212-
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-amd64-azl3.yaml")
213-
else:
214-
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-arm64-azl3.yaml")
211+
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-azl3.yaml")
215212
output_format = "qcow2"
216213

217214
run_min_change_test(
@@ -242,10 +239,7 @@ def test_min_change_efi_azl4_qcow_output(
242239
close_list: List[Closeable],
243240
) -> None:
244241
azl_release = 4
245-
if platform.machine() == "x86_64":
246-
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-amd64-azl4.yaml")
247-
else:
248-
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-arm64-azl4.yaml")
242+
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-azl4.yaml")
249243
output_format = "qcow2"
250244

251245
run_min_change_test(
@@ -309,7 +303,7 @@ def test_min_change_legacy_azl3_qcow_output(
309303
close_list: List[Closeable],
310304
) -> None:
311305
azl_release = 3
312-
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-amd64-azl3.yaml")
306+
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-azl3.yaml")
313307
output_format = "qcow2"
314308

315309
run_min_change_test(
@@ -341,7 +335,7 @@ def test_min_change_legacy_azl4_qcow_output(
341335
close_list: List[Closeable],
342336
) -> None:
343337
azl_release = 4
344-
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-amd64-azl4.yaml")
338+
config_path = TEST_CONFIGS_DIR.joinpath("os-vm-config-azl4.yaml")
345339
output_format = "qcow2"
346340

347341
run_min_change_test(

test/vmtests/vmtests/osmodifier/test_osmodifier.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
import logging
55
import os
6-
import platform
76
import tempfile
87
from pathlib import Path
98
from typing import List, Tuple
@@ -37,10 +36,7 @@ def setup_vm_with_osmodifier(
3736
libvirt_conn: libvirt.virConnect,
3837
session_close_list: List[Closeable],
3938
) -> Tuple[SshClient, Path, Path]:
40-
if platform.machine() == "x86_64":
41-
config_path = TEST_CONFIGS_DIR.joinpath("osmodifier-vm-config.yaml")
42-
else:
43-
config_path = TEST_CONFIGS_DIR.joinpath("osmodifier-vm-config-arm64.yaml")
39+
config_path = TEST_CONFIGS_DIR.joinpath("osmodifier-vm-config.yaml")
4440

4541
output_format = "qcow2"
4642
ssh_public_key, ssh_private_key_path = ssh_key

toolkit/tools/pkg/imagecustomizerlib/testdata/os-vm-config-arm64-azl3.yaml

Lines changed: 0 additions & 10 deletions
This file was deleted.

toolkit/tools/pkg/imagecustomizerlib/testdata/os-vm-config-arm64-azl4.yaml

Lines changed: 0 additions & 11 deletions
This file was deleted.

toolkit/tools/pkg/imagecustomizerlib/testdata/os-vm-config-amd64-azl3.yaml renamed to toolkit/tools/pkg/imagecustomizerlib/testdata/os-vm-config-azl3.yaml

File renamed without changes.

toolkit/tools/pkg/imagecustomizerlib/testdata/os-vm-config-amd64-azl4.yaml renamed to toolkit/tools/pkg/imagecustomizerlib/testdata/os-vm-config-azl4.yaml

File renamed without changes.

toolkit/tools/pkg/imagecustomizerlib/testdata/osmodifier-vm-config-arm64.yaml

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)