Skip to content

Add image creator #258

Merged
himaja-kesari merged 5 commits into
mainfrom
user/himajakesari/seeder
Jun 20, 2025
Merged

Add image creator #258
himaja-kesari merged 5 commits into
mainfrom
user/himajakesari/seeder

Conversation

@himaja-kesari
Copy link
Copy Markdown
Contributor

@himaja-kesari himaja-kesari commented Jun 3, 2025

This PR adds a new tool image creator that creates seed images
Added a new module for image creator
Added a new share testutils module

follow-up PRs:

  1. validation logic and tests for image creator configs, tests to check the actual contents of the image. e.g. installed packages, grub.cfg files, etc.
  2. Add cli argument for release version to support 2.0/3.0/4.0 AZL packages installation, packagesnapshot time
  3. Support for fedora
  4. doc updates to run imagecreator and test

Checklist

  • Tests added/updated
  • Documentation updated (if needed)
  • Code conforms to style guidelines

@himaja-kesari himaja-kesari requested a review from a team as a code owner June 3, 2025 16:17
@himaja-kesari himaja-kesari marked this pull request as draft June 3, 2025 16:17
Comment thread toolkit/tools/imager/imager.go Fixed
Comment thread toolkit/tools/imager/imager.go
Comment thread toolkit/tools/imager/imager.go
Comment thread toolkit/tools/pkg/imagecustomizerlib/customizeos.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/customizepackages.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/customizepackages.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/customizeos.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/customizeos.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go
@himaja-kesari himaja-kesari force-pushed the user/himajakesari/seeder branch from 89eb121 to 19220fb Compare June 3, 2025 20:48
@himaja-kesari himaja-kesari requested a review from cwize1 June 6, 2025 21:04
Comment thread toolkit/scripts/build_tag_imagecreator.mk Outdated
Comment thread toolkit/scripts/tools.mk Outdated
Comment thread toolkit/tools/internal/safechroot/safechroot.go Outdated
Comment thread toolkit/tools/imagecreator/main.go Outdated
Comment thread toolkit/tools/pkg/imagecreatorlib/imagecreator.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/customizepackages.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/imagecreator.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/imagecreator.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/imagecreator.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/imagecreator.go
Comment thread toolkit/tools/imagecreator/main.go Dismissed
Comment thread toolkit/tools/pkg/imagecreatorlib/imagecreator.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/customizepackages.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/imagecustomizer.go Outdated
@himaja-kesari himaja-kesari changed the title push seeder code Add image creator Jun 17, 2025
@himaja-kesari himaja-kesari marked this pull request as ready for review June 17, 2025 16:51
@himaja-kesari himaja-kesari force-pushed the user/himajakesari/seeder branch from 24e6a09 to 504361e Compare June 17, 2025 17:30
Comment thread toolkit/tools/internal/testutils/testrpms/download-test-rpms.sh Outdated
Comment thread toolkit/tools/internal/testutils/testrpms/download-test-rpms.sh Outdated
Comment thread toolkit/tools/internal/testutils/testrpms/downloader/Dockerfile Outdated
Comment thread toolkit/tools/internal/testutils/testrpms/downloader/Dockerfile
Comment thread toolkit/tools/internal/testutils/testrpms/downloader/Dockerfile Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/artifactsinputoutput.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/customizebootloader.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/main_test.go Outdated
Comment thread toolkit/tools/pkg/imagecreatorlib/imagecreator_test.go Outdated
Comment thread toolkit/tools/pkg/imagecustomizerlib/customizepackages_test.go Outdated
@himaja-kesari himaja-kesari force-pushed the user/himajakesari/seeder branch from 7941a85 to f92cde9 Compare June 18, 2025 22:56
Comment thread toolkit/tools/internal/testutils/testrpms/download-test-rpms.sh Outdated
@himaja-kesari himaja-kesari force-pushed the user/himajakesari/seeder branch 6 times, most recently from 21d3518 to 1127c25 Compare June 19, 2025 23:46
resolve comments

revert changes in imager code

resolve feedback

fix issues with bindmounts

add tests

fix rebase

resolve comments

resolve comments

skip imagecreation tests by default

resolve feedback
@himaja-kesari himaja-kesari force-pushed the user/himajakesari/seeder branch from 58c9305 to 5222518 Compare June 19, 2025 23:55
@himaja-kesari himaja-kesari requested a review from cwize1 June 20, 2025 00:17
cwize1
cwize1 previously approved these changes Jun 20, 2025
@himaja-kesari himaja-kesari requested a review from cwize1 June 20, 2025 21:28
@himaja-kesari himaja-kesari merged commit 9a0278c into main Jun 20, 2025
8 checks passed
@himaja-kesari himaja-kesari deleted the user/himajakesari/seeder branch June 20, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants