Make base image input to functional tests more generic.#264
Merged
Conversation
cwize1
force-pushed
the
user/chrisgun/testBaseImageRefactor
branch
from
97de61b to
5f4c977
Compare
1. Change base image info from a set of parameters to a combined struct. This will make it eaiser to pass the info around. It also makes it easier to add additional properties. 2. Change the default base image from a constant to a priority list. This will make it easier to manually run the image independent tests on other images.
cwize1
force-pushed
the
user/chrisgun/testBaseImageRefactor
branch
from
5f4c977 to
93cb66c
Compare
gmileka
reviewed
Jun 12, 2025
gmileka
reviewed
Jun 12, 2025
gmileka
approved these changes
Jun 12, 2025
himaja-kesari
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change base image info from a set of parameters to a combined struct. This will make it eaiser to pass the info around. It also makes it easier to add additional properties.
Change the default base image from a constant to a priority list. This will make it easier to manually run the image independent tests on other images.
Checklist