OSModifier: Restore SELinux config file update for UKI-based boot#266
Merged
Conversation
cwize1
approved these changes
Jun 10, 2025
bfjelds
reviewed
Jun 10, 2025
| return err | ||
| } | ||
|
|
||
| err = imagecustomizerlib.UpdateSELinuxModeInConfigFile(selinuxMode, dummyChroot) |
Member
There was a problem hiding this comment.
Can a test be added to ensure this isn't removed in future?
3 tasks
elainezhao1
added a commit
that referenced
this pull request
Jun 13, 2025
…cenarios (#269) <!-- Description: Please provide a summary of the changes and the motivation behind them. --> a follow up for #266 Enhance boot customization logic to distinguish GRUB and UKI scenarios - Introduce explicit checks for /boot/grub2/grub.cfg and /etc/default/grub to determine if GRUB is in use. - Conditionally apply GRUB-specific logic (e.g., kernel command line updates, SELinux boot parameters) only when GRUB is present. - Refactor SELinux handling into updateSELinuxForGrubBasedBoot and updateSELinuxForUkiBoot for clarity and separation of concerns. --- ### **Checklist** - [ ] Tests added/updated - [ ] Documentation updated (if needed) - [ ] Code conforms to style guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores a missing call to UpdateSELinuxModeInConfigFile() in the SELinux setup logic. It was unintentionally removed earlier.
Checklist