Support cosi output type for injection API.#268
Merged
Conversation
cwize1
requested changes
Jun 12, 2025
| if err != nil { | ||
| return fmt.Errorf("failed to convert customized raw image to output format:\n%w", err) | ||
| if detectedImageFormat == imagecustomizerapi.ImageFormatTypeCosi { | ||
| imageConnection, partUuidToFstabEntry, baseImageVerityMetadata, err := connectToExistingImage(rawImageFile, |
Contributor
There was a problem hiding this comment.
Move the collection of osRelease and osPackages into a function, to help make the code a little cleaner.
Contributor
There was a problem hiding this comment.
Sorry, I should have been more specific. I meant create a helper function that covers connectToExistingImage to CleanClose.
Contributor
Author
There was a problem hiding this comment.
I see, please check it again.
cwize1
requested changes
Jun 12, 2025
| if err != nil { | ||
| return fmt.Errorf("failed to convert customized raw image to output format:\n%w", err) | ||
| if detectedImageFormat == imagecustomizerapi.ImageFormatTypeCosi { | ||
| imageConnection, partUuidToFstabEntry, baseImageVerityMetadata, err := connectToExistingImage(rawImageFile, |
Contributor
There was a problem hiding this comment.
Sorry, I should have been more specific. I meant create a helper function that covers connectToExistingImage to CleanClose.
liulanze
force-pushed
the
user/lanzeliu/io-cosi-output-type
branch
from
b77ea21 to
7ad78e8
Compare
cwize1
requested changes
Jun 13, 2025
| partUuidToFstabEntry map[string]diskutils.FstabEntry, verityMetadata []verityDeviceMetadata, | ||
| osRelease string, osPackages []OsPackage, imageUuid [UuidSize]byte, imageUuidStr string, | ||
| ) error { | ||
| outputImageBase := strings.TrimSuffix(filepath.Base(outputImageFile), filepath.Ext(outputImageFile)) |
Contributor
There was a problem hiding this comment.
To be honest, we could probably give the partition files a standard base name of partition instead of it being dynamic. This user isn't going to see these files anyway.
Contributor
Author
There was a problem hiding this comment.
Fixed, please check again.
| if err != nil { | ||
| return fmt.Errorf("failed to convert customized raw image to output format:\n%w", err) | ||
| if detectedImageFormat == imagecustomizerapi.ImageFormatTypeCosi { | ||
| imageConnection, partUuidToFstabEntry, baseImageVerityMetadata, err := connectToExistingImage(rawImageFile, |
cwize1
approved these changes
Jun 13, 2025
liulanze
force-pushed
the
user/lanzeliu/io-cosi-output-type
branch
from
f8a1d27 to
6ee21bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support users to set output image type as COSI when injection API gets called.
Checklist