Skip to content

Add methods to toggle web sockets in app services#2512

Open
ilnarag wants to merge 1 commit into
microsoft:developfrom
ilnarag:app-service-toggle-web-sockets
Open

Add methods to toggle web sockets in app services#2512
ilnarag wants to merge 1 commit into
microsoft:developfrom
ilnarag:app-service-toggle-web-sockets

Conversation

@ilnarag

@ilnarag ilnarag commented Nov 20, 2024

Copy link
Copy Markdown

Added methods to enable/disable web sockets on App Services

@Flanker32 Flanker32 requested a review from Copilot December 22, 2024 02:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

azure-toolkit-libs/azure-toolkit-appservice-lib/src/main/java/com/microsoft/azure/toolkit/lib/appservice/webapp/WebAppDeploymentSlot.java:42

  • Ensure that the behavior introduced by the toggleWebSockets method is covered by tests.
doModify(() -> Objects.requireNonNull(getRemote()).update().withWebSocketsEnabled(enabled).apply(), Status.UPDATING);

@ilnarag

ilnarag commented Jan 17, 2025

Copy link
Copy Markdown
Author

We have decided to implement it on our side first: JetBrains/azure-tools-for-intellij#1001

@wangmingliang-ms wangmingliang-ms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants