Add versionFilePath to UseNode@1#22189
Open
bdukes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #22131
Task Name
UseNode@1
Description
Adds a
versionFilePathinput to UseNode@1 so that version specs can be stored in a file (e.g..nvmrcor.node-version), instead of duplicated in the Pipelines config.Risk Assessment (Low / Medium / High)
Low. This change is backwards compatible and requires a developer to opt in to using the new input.
Change Behind Feature Flag (Yes / No)
This adds a new input field, I don't know whether or not that can be feature flagged.
Tech Design / Approach
This approach used the same basic idea as NodeTool@0 and UseDotnet@2
Documentation Changes Required (Yes/No)
Yes, there is a new input field.
Unit Tests Added or Updated (Yes / No)
No
Additional Testing Performed
Verified automated tests did not have additional failures.
Logging Added/Updated (Yes/No)
No
Telemetry Added/Updated (Yes/No)
No
Rollback Scenario and Process (Yes/No)
No
Dependency Impact Assessed and Regression Tested (Yes/No)
No
Checklist