more feedback

Author: dmcilvaney

.github/instructions/rendered-specs.instructions.md

@@ -7,7 +7,7 @@ description: ALWAYS refer to this when working with rendered spec files (`*.spec
 
 ## What are rendered specs?
 
-Rendered specs are generated by the `azldev component render` command based on the component definitions and overlays. They are output to the `specs/` directory and should not be edited directly.
+Rendered specs are generated by the `azldev comp render` command based on the component definitions and overlays. They are output to the `specs/` directory and should not be edited directly.
 
 They are meant to be consumed by downstream processes (e.g., build pipelines) and are the source of truth for all subsequent steps. Any changes to the spec should be made via the component definition and overlays, not by editing the rendered spec.
 
@@ -17,16 +17,16 @@ To change a rendered spec, modify the component's `.comp.toml` and/or its overla
 
 ```bash
 # VERY SLOW - Re-render all specs, removes any stale specs that are no longer defined in the components
-azldev component render -a --clean-stale -O json
+azldev comp render -a --clean-stale -O json
 ```
 
 ```bash
 # Small set, will NOT remove stale specs, faster for iterative development
-azldev component render <component-1> <component-2> -O json
+azldev comp render <component-1> <component-2> -O json
 ```
 
 ```bash
 # Custom output directory, useful for debugging. When not using the automatically configured spec directory, --force is
 # required to delete and re-create the output folders if they already exist.
-azldev component render <component> -O json -o ./base/build/work/scratch/rendered-specs --force
+azldev comp render <component> -O json -o ./base/build/work/scratch/rendered-specs --force
 ```

.github/workflows/scripts/check_rendered_specs.py

@@ -354,8 +354,8 @@ def main() -> int:
             + _unique_components(report.get("missing_files", []))
         )
     )
-    if extra:
-        print("Remediation: azldev component render -a")
+    if extra or missing:
+        print(f"Remediation: {_render_command([], use_all=True)}")
     elif all_comps:
         print(f"Remediation: {_render_command(all_comps)}")
 

.github/workflows/scripts/post_render_comment.py

@@ -29,6 +29,7 @@
 import os
 import subprocess
 import sys
+import tempfile
 from pathlib import Path
 
 # ---------------------------------------------------------------------------
@@ -231,9 +232,10 @@ def find_existing_comment(repo: str, pr: str) -> str | None:
 
 def post_or_update_comment(repo: str, pr: str, body: str) -> None:
     existing_id = find_existing_comment(repo, pr)
-    body_path = Path("render-check-comment.md")
-    body_path.write_text(body, encoding="utf-8")
+    fd, body_path = tempfile.mkstemp(prefix="render-check-comment-", suffix=".md")
     try:
+        with os.fdopen(fd, "w") as f:
+            f.write(body)
         if existing_id:
             print(f"Updating existing comment {existing_id}")
             _gh(
@@ -246,9 +248,9 @@ def post_or_update_comment(repo: str, pr: str, body: str) -> None:
             )
         else:
             print("Creating new comment")
-            _gh("pr", "comment", pr, "--repo", repo, "--body-file", str(body_path))
+            _gh("pr", "comment", pr, "--repo", repo, "--body-file", body_path)
     finally:
-        body_path.unlink(missing_ok=True)
+        Path(body_path).unlink(missing_ok=True)
 
 
 def delete_comment_if_exists(repo: str, pr: str) -> None:

README.md

@@ -22,7 +22,7 @@ go install github.com/microsoft/azure-linux-dev-tools/cmd/azldev@main
 
 The `specs/` directory contains "rendered" spec files created by `azldev`. They are a read-only snapshot of the final spec files after all overlays and modifications have been applied. They are the canonical source for what will be built and packaged.
 
-They can be updated at any time by running `azldev comp render -a`, or a single component can be rendered with `azldev comp render <name>`.
+They can be updated at any time by running `azldev component render -a`, or a single component can be rendered with `azldev component render <name>`.
 
 ## AI-Assisted Development (VSCode + GitHub Copilot CLI)