fix(mcp): move mcp scripts to folder linters can read

Author: dmcilvaney

.vscode/mcp.json

@@ -4,14 +4,14 @@
 			"type": "stdio",
 			"command": "python3",
 			"args": [
-				".vscode/mcps/koji-mcp.py"
+				"scripts/mcps/koji-mcp.py"
 			]
 		},
 		"fedora-distgit": {
 			"type": "stdio",
 			"command": "python3",
 			"args": [
-				".vscode/mcps/fedora-distgit-mcp.py"
+				"scripts/mcps/fedora-distgit-mcp.py"
 			]
 		},
 		"azure-mcp-server": {
@@ -70,4 +70,4 @@
 			"password": false
 		}
 	]
-}
+}

DEVELOPING.md

@@ -34,10 +34,10 @@ The `azl-diagnose` agent and Koji-related tools require:
 
 1. **MCP Python packages** — the MCP servers won't start without them:
    ```bash
-   pip3 install --user -r .vscode/mcps/requirements.txt
+   pip3 install --user -r scripts/mcps/requirements.txt
    ```
 2. **Network access to the internal Koji instance** — The internal Koji is only accessible via VPN or the corporate network. If the agent reports connection errors, verify you are connected before retrying.
-3. **(Optional) `.env` configuration** — Create a `.env` file (in the workspace root or `.vscode/mcps/`) to pre-configure MCP server settings like the Koji base URL and pre-approved insecure URLs. This avoids the agent having to set the URL or approve self-signed certificates every session. See [.vscode/mcps/.env.example](.vscode/mcps/.env.example) for available variables.
+3. **(Optional) `.env` configuration** — Create a `.env` file (in the workspace root or `scripts/mcps/`) to pre-configure MCP server settings like the Koji base URL and pre-approved insecure URLs. This avoids the agent having to set the URL or approve self-signed certificates every session. See [scripts/mcps/.env.example](scripts/mcps/.env.example) for available variables.
 
 Ask Copilot about any aspect of the project — it can reference the instructions and skills to provide detailed, actionable answers or perform tasks. For example:
 

scripts/batch-triage/triage.sh

@@ -78,7 +78,7 @@ REPO_ROOT="$(git -C "$SCRIPT_DIR" rev-parse --show-toplevel)"
 
 # Always build — layer caching makes this fast when nothing changed
 # Copy requirements.txt into the build context (COPY can't reach outside it)
-cp "${REPO_ROOT}/.vscode/mcps/requirements.txt" "${SCRIPT_DIR}/requirements.txt"
+cp "${REPO_ROOT}/scripts/mcps/requirements.txt" "${SCRIPT_DIR}/requirements.txt"
 # Trap will not fire for exec, but will cover cleanup if the build step fails
 trap 'rm -f "${SCRIPT_DIR}/requirements.txt"' EXIT
 
@@ -103,13 +103,16 @@ DOCKER_ARGS+=( -u "$(id -u):$(id -g)" )
 
 # Require a .env file for MCP server config (Koji URL, auth, etc.)
 ENV_FILE=""
-if [[ -f "${REPO_ROOT}/.vscode/mcps/.env" ]]; then
-    ENV_FILE="${REPO_ROOT}/.vscode/mcps/.env"
-elif [[ -f "${REPO_ROOT}/.env" ]]; then
+if [[ -f "${REPO_ROOT}/.env" ]]; then
     ENV_FILE="${REPO_ROOT}/.env"
+elif [[ -f "${REPO_ROOT}/scripts/mcps/.env" ]]; then
+    ENV_FILE="${REPO_ROOT}/scripts/mcps/.env"
+elif [[ -f "${REPO_ROOT}/.vscode/mcps/.env" ]]; then
+    # Legacy location from when MCP scripts lived under .vscode/mcps/
+    ENV_FILE="${REPO_ROOT}/.vscode/mcps/.env"
 else
-    echo "Error: No .env file found. Create one at .env in the repo root or .vscode/mcps/.env" >&2
-    echo "See .vscode/mcps/.env.example for required variables." >&2
+    echo "Error: No .env file found. Create one at .env in the repo root or scripts/mcps/.env" >&2
+    echo "See scripts/mcps/.env.example for required variables." >&2
     echo "Koji MCP will not auto-configure without this file." >&2
     exit 1
 fi

.vscode/mcps/.env.example scripts/mcps/.env.example.vscode/mcps/.env.example renamed to scripts/mcps/.env.example

@@ -2,7 +2,7 @@
 #
 # Copy this file to .env to one of the following locations to set environment variables for the MCP servers:
 #  - .env in the workspace root
-#  - .vscode/mcps/.env
+#  - scripts/mcps/.env
 #
 # These variables are loaded by the MCP servers at startup. They can also
 # be set as regular environment variables (env vars take precedence).

.vscode/mcps/_mcp_utils.py scripts/mcps/_mcp_utils.py.vscode/mcps/_mcp_utils.py renamed to scripts/mcps/_mcp_utils.py

@@ -1,5 +1,4 @@
-"""
-Shared utilities for Azure Linux MCP servers.
+"""Shared utilities for Azure Linux MCP servers.
 
 Provides common helpers for URL validation, SSRF guards, output handling,
 and .env file loading so individual MCP servers stay DRY.
@@ -18,7 +17,7 @@
 # Return type for all MCP tools — values may be str, int, list, or None.
 StatusDict = dict[str, Any]
 
-_INSTALL_HINT = "Install with:  pip3 install --user -r .vscode/mcps/requirements.txt"
+_INSTALL_HINT = "Install with:  pip3 install --user -r scripts/mcps/requirements.txt"
 
 try:
     from dotenv import load_dotenv
@@ -50,8 +49,9 @@ def load_env(env_path: str | Path | None = None) -> None:
       1. Explicit ``env_path`` argument
       2. ``.env`` in the current working directory
       3. ``.env`` in the workspace root (two dirs up from this source file)
-      4. ``.vscode/mcps/.env`` relative to the working directory
-      5. ``.vscode/mcps/.env`` next to this source file
+      4. ``scripts/mcps/.env`` next to this source file
+      5. ``.vscode/mcps/.env`` relative to the working directory (legacy)
+      6. ``.vscode/mcps/.env`` in the workspace root (legacy)
 
     Uses python-dotenv for parsing. Existing env vars are NOT overridden.
     """
@@ -60,8 +60,10 @@ def load_env(env_path: str | Path | None = None) -> None:
         candidates.append(Path(env_path))
     candidates.append(Path.cwd() / ".env")
     candidates.append(Path(__file__).resolve().parent.parent.parent / ".env")
-    candidates.append(Path.cwd() / ".vscode" / "mcps" / ".env")
     candidates.append(Path(__file__).resolve().parent / ".env")
+    # Legacy locations from when MCP scripts lived under .vscode/mcps/
+    candidates.append(Path.cwd() / ".vscode" / "mcps" / ".env")
+    candidates.append(Path(__file__).resolve().parent.parent.parent / ".vscode" / "mcps" / ".env")
 
     for c in candidates:
         if c.is_file():

.vscode/mcps/fedora-distgit-mcp.py scripts/mcps/fedora-distgit-mcp.py.vscode/mcps/fedora-distgit-mcp.py renamed to scripts/mcps/fedora-distgit-mcp.py

@@ -75,7 +75,7 @@
     )
 
 
-def _add_status(result: StatusDict, *, full: bool) -> StatusDict:
+def _add_status(result: StatusDict, full: bool) -> StatusDict:
     """Build a snapshot of the MCP server's current state."""
     status = {
         "default_base_url": _base_url,