Skip to content

Commit 9c77e19

Browse files
committed
fix(webkitgtk): drop vestigial gstreamer-plugins-bad BR
gstreamer1-plugins-bad-free is not shipped in AZL, so the hard BuildRequires on pkgconfig(gstreamer-plugins-bad-1.0) caused dnf builddep to fail during chroot init. The BR is vestigial in the upstream Fedora spec: under default cmake options the WebKitGTK 2.50 sources do not #include any gst-plugins-bad headers (gst-bad headers are only reached via GSTREAMER_MPEGTS / GSTREAMER_WEBRTC / LIBWEBRTC, all of which default OFF for the GTK port). Removing the BR alone unblocks the build without changing any runtime feature surface.
1 parent f526821 commit 9c77e19

3 files changed

Lines changed: 20 additions & 4 deletions

File tree

base/comps/webkitgtk/webkitgtk.comp.toml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@
55
# gstreamer1-plugins-bad-free is not shipped in AZL. WebKitGTK only
66
# soft-recommends it for optional codec support; removing the Recommends
77
# prevents package managers from trying to pull in a non-existent package.
8+
# The hard BuildRequires on pkgconfig(gstreamer-plugins-bad-1.0) in the
9+
# Fedora spec is vestigial — under default cmake options the WebKitGTK
10+
# 2.50 sources do not actually #include any gst-plugins-bad headers
11+
# (gst-bad is only reached via GSTREAMER_MPEGTS / GSTREAMER_WEBRTC /
12+
# LIBWEBRTC code paths, all of which default OFF for the GTK port).
13+
# Removing just the BR is therefore sufficient to unblock the build
14+
# without changing any runtime feature surface (MSE/EME stay at their
15+
# upstream defaults).
816

917
[components.webkitgtk]
1018

@@ -15,7 +23,13 @@ tag = "BuildRequires"
1523
value = "pkgconfig(libavif)"
1624

1725
[[components.webkitgtk.overlays]]
18-
description = "Disable avif support in WebKitGTK cmake builds"
26+
description = "Remove gstreamer-plugins-bad-1.0 BuildRequires (gstreamer1-plugins-bad-free not shipped in AZL; vestigial in upstream spec, no gst-bad headers are #included under default cmake options)"
27+
type = "spec-remove-tag"
28+
tag = "BuildRequires"
29+
value = "pkgconfig(gstreamer-plugins-bad-1.0)"
30+
31+
[[components.webkitgtk.overlays]]
32+
description = "Disable avif support in WebKitGTK cmake builds (libavif not available in AZL)"
1933
type = "spec-search-replace"
2034
section = "%build"
2135
regex = '%cmake \\'

locks/webkitgtk.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
version = 1
33
import-commit = '1a9da7e82122526bd080d6c83afea2cf5a7d083d'
44
upstream-commit = '1a9da7e82122526bd080d6c83afea2cf5a7d083d'
5-
input-fingerprint = 'sha256:be1846a272a139b429ffe3d470467a4400821eba81b3368a3609f552ebfdb971'
5+
input-fingerprint = 'sha256:0e8ddb60325dc8f6b3ceda610c26a3502bebcb13ae691a10776c01eddc017f11'
66
resolution-input-hash = 'sha256:466421704711c4fd3c71f0b2ed715a0e61d49e3e26f3a2637fee755795849c8e'

specs/w/webkitgtk/webkitgtk.spec

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
## (rpmautospec version 0.8.3)
33
## RPMAUTOSPEC: autorelease, autochangelog
44
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
5-
release_number = 4;
5+
release_number = 5;
66
base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
77
print(release_number + base_release_number - 1);
88
}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
@@ -109,7 +109,6 @@ BuildRequires: pkgconfig(gbm)
109109
BuildRequires: pkgconfig(glib-2.0)
110110
BuildRequires: pkgconfig(gobject-introspection-1.0)
111111
BuildRequires: pkgconfig(gstreamer-1.0)
112-
BuildRequires: pkgconfig(gstreamer-plugins-bad-1.0)
113112
BuildRequires: pkgconfig(gstreamer-plugins-base-1.0)
114113
BuildRequires: pkgconfig(gtk+-3.0)
115114
BuildRequires: pkgconfig(gtk4)
@@ -470,6 +469,9 @@ export NINJA_STATUS="[2/2][%f/%t %es] "
470469

471470
%changelog
472471
## START: Generated by rpmautospec
472+
* Sun May 24 2026 Chris Co <chrco@microsoft.com> - 2.50.5-5
473+
- fix(webkitgtk): drop vestigial gstreamer-plugins-bad BR
474+
473475
* Thu May 21 2026 Chris Co <chrco@microsoft.com> - 2.50.5-4
474476
- fix(webkitgtk): remove Recommends on gstreamer1-plugins-bad-free
475477

0 commit comments

Comments
 (0)