Skip to content

Commit c9a41f2

Browse files
committed
DROP BEFORE MERGE: enable end-to-end testing from a draft PR
Testing-only commit so we can exercise the full PR-3 flow from a draft PR without merging anywhere. Changes: * Lift the PullRequest skip in run_prcheck.py so prcheck gets called from a draft PR run. * Lift the PullRequest skip in run_package_build.py so package builds get submitted from a draft PR run. * Re-add --scratch-build to the package-build invocation in the YAML so the test pipeline never submits an official build (PR-3 flipped the default to non-scratch / official).
1 parent 7df7dc3 commit c9a41f2

3 files changed

Lines changed: 16 additions & 12 deletions

File tree

.github/workflows/ado/templates/sources-upload-stages.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,6 @@ stages:
224224
--build-reason "$BUILD_REASON" \
225225
--changed-components-file "$CHANGED_COMPONENTS_FILE" \
226226
--package-target azl4 \
227-
--official-build \
228227
--commit-sha "$SOURCE_COMMIT" \
229228
--repo-uri "$UPSTREAM_REPO_URL"
230229
env:

.github/workflows/scripts/control-tower/run_package_build.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,15 @@ def main() -> None:
157157

158158
base_url = args.api_base_url.rstrip("/")
159159

160-
if args.build_reason == "PullRequest":
161-
print(
162-
"Skipping Control Tower call -- pull request triggers do not submit "
163-
"package builds (unmerged code should not consume build capacity)."
164-
)
165-
return
160+
# TESTING-ONLY: PR skip lifted so we can exercise the package-build
161+
# submission from a draft PR. Scratch builds are safe to kick off from
162+
# arbitrary refs. Drop this commit before merging anywhere.
163+
# if args.build_reason == "PullRequest":
164+
# print(
165+
# "Skipping Control Tower call -- pull request triggers do not submit "
166+
# "package builds (unmerged code should not consume build capacity)."
167+
# )
168+
# return
166169

167170
if not components:
168171
print("No components need a rebuild -- skipping package-build submission.")

.github/workflows/scripts/control-tower/run_prcheck.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -181,11 +181,13 @@ def main() -> None:
181181
print("Payload:")
182182
print(json.dumps(payload, indent=2))
183183

184-
if args.build_reason == "PullRequest":
185-
print(
186-
"Skipping Control Tower call - pull request triggers are not supported, yet."
187-
)
188-
return
184+
# TESTING-ONLY: PR skip lifted so we can exercise the prcheck endpoint
185+
# from a draft PR. Drop this commit before merging anywhere.
186+
# if args.build_reason == "PullRequest":
187+
# print(
188+
# "Skipping Control Tower call - pull request triggers are not supported, yet."
189+
# )
190+
# return
189191

190192
if not components:
191193
print(

0 commit comments

Comments
 (0)