Skip to content

[MEDIUM] Patch glib for CVE-2024-34397#15359

Open
archana25-ms wants to merge 9 commits intomicrosoft:mainfrom
archana25-ms:topic_glib-2.0
Open

[MEDIUM] Patch glib for CVE-2024-34397#15359
archana25-ms wants to merge 9 commits intomicrosoft:mainfrom
archana25-ms:topic_glib-2.0

Conversation

@archana25-ms
Copy link
Copy Markdown
Contributor

@archana25-ms archana25-ms commented Dec 22, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Patch glib for CVE-2024-34397

CVE-2024-24397 was merged in PR-14223 and was later reverted back in PR-14745 since there was test failure in ModemManager package during full build because of the CVE fix.

Hence in this PR the CVE patch is backported from https://gitlab.gnome.org/GNOME/glib/-/issues/3268#fixes
and verified the test execution of ModemManager package with the fixed glib present in toolchain.

Change Log
  • added: SPECS/glib/CVE-2024-34397.patch
  • modified: SPECS/glib/glib.spec
  • modified: toolkit/resources/manifests/package/pkggen_core_aarch64.txt
  • modified: toolkit/resources/manifests/package/pkggen_core_x86_64.txt
  • modified: toolkit/resources/manifests/package/toolchain_aarch64.txt
  • modified: toolkit/resources/manifests/package/toolchain_x86_64.txt
Does this affect the toolchain?

YES

Associated issues
Links to CVEs
Test Methodology

Patch applies cleanly

image

Build is Successful

image

Verified ModemManager test with patched glib and its passed

image

@archana25-ms archana25-ms requested a review from a team as a code owner December 22, 2025 11:45
@archana25-ms archana25-ms marked this pull request as draft December 22, 2025 11:51
@archana25-ms archana25-ms marked this pull request as ready for review December 22, 2025 12:13
@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

Buddy Build

@archana25-ms
Copy link
Copy Markdown
Contributor Author

Buddy Build

Buddy build is successful.

@archana25-ms
Copy link
Copy Markdown
Contributor Author

CVE-2024-24397 was merged in PR-14223 and was later reverted back in PR-14745 since there was test failure in ModemManager package during full build because of this CVE fix.

Hence in this PR the CVE patch is backported from https://gitlab.gnome.org/GNOME/glib/-/issues/3268#fixes
and verified the test execution of ModemManager package with the fixed glib present in toolchain.

Requesting for Full build so that other dependency packages test and build can also be verified.

Copy link
Copy Markdown
Contributor

@suresh-thelkar suresh-thelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Since the patch is huge, I have also run the full build given below. Please make sure all the packages and ptests run successfully and pass.

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1038532&view=results

@archana25-ms archana25-ms changed the title [MEDIUM] Patch glib for CVE-2024-34397 [MEDIUM] Patch glib for CVE-2024-34397 and CVE-2026-1484 Jan 29, 2026
@Kanishk-Bansal
Copy link
Copy Markdown
Contributor

Build

@archana25-ms
Copy link
Copy Markdown
Contributor Author

archana25-ms commented Jan 29, 2026

Added another CVE-2025-1484 patch and buddy build link - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1038685&view=results
Buddy build is successful. Waiting for above mentioned full build results

@suresh-thelkar
Copy link
Copy Markdown
Contributor

Added another CVE-2025-1484 patch and buddy build link - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1038685&view=results Buddy build is successful. Waiting for above mentioned full build results

Please make sure that you fix the issues with the full build first and make sure everything goes fine. Then only add this CVE. Probably you can add this CVE in a new PR. Already the patch is huge and adding another CVE patch in the same PR is not advisable according to me.

@archana25-ms archana25-ms changed the title [MEDIUM] Patch glib for CVE-2024-34397 and CVE-2026-1484 [MEDIUM] Patch glib for CVE-2024-34397 Feb 10, 2026
@archana25-ms
Copy link
Copy Markdown
Contributor Author

Removed CVE-2025-1484 from this PR and created new PR - #15774 as requested

Copy link
Copy Markdown
Contributor

@suresh-thelkar suresh-thelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recent code changes look good to me. I have also run the full build, here is is the link - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1077265&view=results

@kgodara912 kgodara912 added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Apr 2, 2026
@archana25-ms
Copy link
Copy Markdown
Contributor Author

archana25-ms commented Apr 21, 2026

@kgodara912
Copy link
Copy Markdown
Contributor

The changes are widespread and previously caused failure for some other package which was dependent on glib. As the CVE is not high or critical and changes are disruptive and can cause failure for users relying on old behavior. We will hold this CVE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants