Skip to content

feat(qemu): disable Xen support #16462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddstreetmicrosoft merged 1 commit into from
Apr 8, 2026
Merged

feat(qemu): disable Xen support #16462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion base/comps/components-full.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4739,7 +4739,6 @@
[components.qcustomplot]
[components.qdbm]
[components.qdox]
[components.qemu]
[components.qhull]
[components.qjson]
[components.qpdf]
Expand Down
10 changes: 10 additions & 0 deletions base/comps/qemu/qemu.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
[components.qemu]

# Disable Xen support — not applicable to Azure Linux's Hyper-V/KVM environment.
# The upstream spec enables Xen when %fedora is set (which it is on our builders),
Copy link
Copy Markdown
Member

@reubeno reubeno Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you look at whether we should be disabling fedora for this spec? What other features are we getting that we wouldn't if we looked more like RHEL?

Copy link
Copy Markdown
Collaborator Author

@christopherco christopherco Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't for this one, but it is a good analysis that can be done. I did a similar evaluation on edk2, but ended up going with fedora's version instead of rhel's since there were some valuable parts that the fedora edk2 build (namely 4MB OVMF support and IGVM). I'll do a similar analysis for qemu

# so we must explicitly override have_xen back to 0.
[[components.qemu.overlays]]
description = "Disable Xen support - not needed for Azure Linux (Hyper-V/KVM only)"
type = "spec-search-replace"
regex = '%global have_xen 1'
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec-search-replace regex is currently an unanchored literal (%global have_xen 1). To reduce fragility and avoid accidental substring matches if the upstream spec changes formatting (extra spaces, trailing conditionals, etc.), consider anchoring the pattern and allowing flexible whitespace (e.g., matching the whole line).

Suggested change
regex = '%global have_xen 1'
regex = '^\s*%global\s+have_xen\s+1\s*$'

Copilot uses AI. Check for mistakes.
replacement = '%global have_xen 0'
Loading