Package Nvidia Open GPU Kernel Modules#16971
Merged
Merged
Conversation
ellie-di
requested review from
christopherco,
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds packaging and build integration for NVIDIA’s open GPU kernel modules as kernel subpackages in Azure Linux 4.0, along with documentation of the kmod framework and workflow.
Changes:
- Introduces a phase-gated kmod subpackage framework (
kmod-macros.inc) and akmod-nvidia-openimplementation (kmod-nvidia-open.inc+ modprobe config). - Updates
kernel.comp.tomlto fetch NVIDIA sources and inject spec overlays for kmod build/install/%files/scriptlets. - Adds a packaging strategy document describing the architecture and onboarding steps for new kmods.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/oss-kmod-packaging-strategy.md | Documents the kmod-as-kernel-subpackage design and onboarding workflow. |
| base/comps/kernel/kmod-nvidia-open.inc | Defines the kmod-nvidia-open subpackage using phase-gated %include sections. |
| base/comps/kernel/kmod-nvidia-open-modprobe.conf | Adds modprobe configuration to avoid nouveau conflicts. |
| base/comps/kernel/kmod-macros.inc | Provides a small framework/registry for kmod subpackages included by the kernel spec. |
| base/comps/kernel/kernel.comp.toml | Downloads NVIDIA sources and injects the necessary spec overlays to build/package the kmod. |
ellie-di
force-pushed
the
edehghani/kmod-framework-for-kernel
branch
3 times, most recently
from
0f3665a to
5ab292c
Compare
christopherco
requested changes
May 7, 2026
henryli001
reviewed
May 11, 2026
henryli001
reviewed
May 11, 2026
ddstreetmicrosoft
requested changes
May 11, 2026
ddstreetmicrosoft
left a comment
ddstreetmicrosoft
left a comment
There was a problem hiding this comment.
issue: please rebase this into discrete, logical commits as they should appear in the repo
ellie-di
force-pushed
the
edehghani/kmod-framework-for-kernel
branch
from
291ebc1 to
2c47662
Compare
ellie-di
force-pushed
the
edehghani/kmod-framework-for-kernel
branch
6 times, most recently
from
917eb67 to
c9db743
Compare
henryli001
reviewed
May 13, 2026
christopherco
force-pushed
the
edehghani/kmod-framework-for-kernel
branch
3 times, most recently
from
c7895a5 to
d7a0f3b
Compare
ddstreetmicrosoft
approved these changes
May 14, 2026
ddstreetmicrosoft
left a comment
ddstreetmicrosoft
left a comment
There was a problem hiding this comment.
I left some comments and questions, but I don't see anything that is blocking. Any issues can be adjusted later, preferably after we change over to a local spec file (which I think will simplify this)
christopherco
requested changes
May 16, 2026
ellie-di
force-pushed
the
edehghani/kmod-framework-for-kernel
branch
from
d7a0f3b to
6b3dcaf
Compare
ellie-di
force-pushed
the
edehghani/kmod-framework-for-kernel
branch
from
6b3dcaf to
7df63da
Compare
rlmenge
approved these changes
May 27, 2026
ellie-di
force-pushed
the
edehghani/kmod-framework-for-kernel
branch
from
7df63da to
455e0c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds packaging and build integration for NVIDIA’s open GPU kernel modules as kernel subpackages in Azure Linux 4.0, along with documentation of the kmod framework and workflow.
Test Methodology
CT package build Job ID: 7fe37879-b457-4ef8-cfa7-08deaca112e9
Successfully ran nvidia-smi on A100 VM: