[DO NOT MERGE] Testing new delta build flow#17066
Draft
dmcilvaney wants to merge 4 commits into
Draft
Conversation
dmcilvaney
force-pushed
the
damcilva/test_build
branch
22 times, most recently
from
266eac2 to
f490289
Compare
The 'compute_changed.sh' and 'compute_render_set.py' helpers are about to be reused by the GH Actions Check Rendered Specs gate. Move them out of the CT-only directory and trim CT-specific behavior: - Drop --publish-dir + trap (callers handle artifact publication). - Drop ADO ##[group] log markers (callers add their own per-pipeline). - Drop baked-in AZLDEV_ALLOW_ROOT step-env. azldev calls inside the helper retain an inline 'AZLDEV_ALLOW_ROOT=1' prefix per .github/instructions/ado-pipeline.instructions.md, so callers do not need to lift the restriction at step scope. - Drop the 'Upload set' jq report (CT-flow specific; moved inline to the CT pipeline YAML alongside the artifact-publish wrapper). CT pipeline call sites are updated to point at the new paths and to re-wrap the call with the log groups and publish-dir cp that used to live in the script.
Testing-only commit so we can exercise the full PR-3 flow from a draft PR without merging anywhere. Changes: * Lift the PullRequest skip in run_prcheck.py so prcheck gets called from a draft PR run. * Lift the PullRequest skip in run_package_build.py so package builds get submitted from a draft PR run. * Re-add --scratch-build to the package-build invocation in the YAML so the test pipeline never submits an official build (PR-3 flipped the default to non-scratch / official).
Adds a Summary tweak via spec-search-replace overlay so 'azldev component changed' reports words with changeType=changed. The spec Source: URL and lookaside sources file stay at their upstream values so Control Tower can actually fetch the tarball and rebuild. Sources file is unchanged from upstream, so sourcesChange=false and the prcheck upload path is skipped. The package-build path is the one being exercised here. Drop this commit before merging anywhere.
Removes cvsps component + specs + lock. The specs-diff render set should NOT include cvsps because --diff-filter=d excludes deleted paths. azldev component changed should report changeType=deleted which is also excluded from the render set. Net: cvsps should not appear in the render set or trigger a render call. Drop this commit before merging anywhere.
dmcilvaney
force-pushed
the
damcilva/test_build
branch
from
f490289 to
f4a44d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology