ci: Make ADO PR scripts available for use by GitHub workflows#17188
Merged
christopherco merged 2 commits intoMay 15, 2026
Merged
Conversation
Pure file move -- 'compute_changed.sh' and 'compute_render_set.py' are about to be reused by the GH Actions Check Rendered Specs gate. A follow-up commit trims CT-specific behavior from compute_changed.sh (--publish-dir flag, ADO log markers, step-env AZLDEV_ALLOW_ROOT) and restructures the CT pipeline call site to absorb that behavior at the caller. No script content changes here -- two line touches in sources-upload-stages.yml and render_and_verify.sh to point at the new paths.
The 'compute_changed.sh' helper just moved to scripts/components/ so it can be reused by the GH Actions Check Rendered Specs gate. Trim the CT-specific behavior that does not generalize: - Drop --publish-dir + trap (callers handle artifact publication). - Drop ADO ##[group] log markers (callers add their own per-pipeline). - Drop baked-in AZLDEV_ALLOW_ROOT step-env (callers handle azldev's no-root policy themselves; the helpers add inline AZLDEV_ALLOW_ROOT=1 prefixes in a follow-up commit when they grow more azldev calls). - Drop the 'Upload set' jq report (CT-flow specific; moved inline to the CT pipeline YAML alongside the artifact-publish wrapper). The CT pipeline call site is restructured to absorb the dropped behavior: a publish_artifact() trap wraps the call, log groups frame each section, and AZLDEV_ALLOW_ROOT=1 is set on the step's env: block. This keeps the existing CT-side artifact and log output identical while letting the helper itself stay pipeline-agnostic.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors ADO PR-check helper scripts so they can be reused by GitHub Actions workflows. The component-set computation logic is moved out of control-tower/ (which is ADO-specific) into a neutral components/ directory. The ADO-specific concerns (artifact publish trap, log grouping, AZLDEV_ALLOW_ROOT env) are hoisted up into the calling pipeline step.
Changes:
- Move
compute_changed.shandcompute_render_set.pyfromscripts/control-tower/toscripts/components/, stripping ADO-only concerns from the shell helper. - Update
sources-upload-stages.ymlto inline the artifact-publish trap and log grouping previously embedded in the script, and setAZLDEV_ALLOW_ROOT=1via the stepenv:block. - Update
render_and_verify.shto reference the relocatedcompute_render_set.py.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/scripts/components/compute_changed.sh |
New location of the changed-components computation; trimmed of ADO publish/grouping logic and AZLDEV_ALLOW_ROOT (now caller's responsibility). |
.github/workflows/scripts/components/compute_render_set.py |
Relocated render-set computation script (logic unchanged). |
.github/workflows/scripts/control-tower/compute_changed.sh |
Old script removed after move. |
.github/workflows/scripts/control-tower/render_and_verify.sh |
Updated path to components/compute_render_set.py. |
.github/workflows/ado/templates/sources-upload-stages.yml |
Inlines the artifact-publish trap, log groups, and AZLDEV_ALLOW_ROOT=1 env around the relocated compute_changed.sh invocation. |
dmcilvaney
force-pushed
the
damcilva/scoped-gates/move-helpers
branch
from
8072b4e to
e7adc27
Compare
christopherco
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.