fix(python-geographiclib): neutralize MinGW macros to avoid empty subshell#17418
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build failure in the python-geographiclib component caused by previously stripping MinGW install macros while leaving behind an empty subshell (( )) in %install, which triggers a bash syntax error during RPM build on Azure Linux (which does not ship MinGW toolchains).
Changes:
- Add two
%install-scopedspec-search-replaceoverlays to remove the now-orphaned(and)lines. - Refresh the rendered spec output and bump
Releaseaccordingly. - Update the component lock fingerprint to reflect the config change.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| specs/p/python-geographiclib/python-geographiclib.spec | Rendered spec updated (Release bump; MinGW subshell parens removed so %install remains valid). |
| locks/python-geographiclib.lock | Updates input-fingerprint to match the new component configuration. |
| base/comps/python-geographiclib/python-geographiclib.comp.toml | Adds two overlays to strip the orphaned subshell parens in %install. |
reubeno
reviewed
May 24, 2026
…shell
The upstream Fedora spec wraps the MinGW install steps in a subshell:
(
%mingw32_py3_install_wheel
%mingw64_py3_install_wheel
)
%mingw_debug_install_post
Azure Linux does not ship MinGW toolchains, so existing overlays
replaced the MinGW macros with empty strings. That left an empty
`( )` block, which bash rejects with `syntax error near unexpected
token ')'` when %install runs, failing the build.
Change the MinGW %build and %install overlays to substitute the
bash no-op `:` instead of an empty string. The subshell stays
syntactically valid and the macros become true no-ops at runtime.
christopherco
force-pushed
the
chrco/fix-python-geographiclib
branch
from
27fbb2f to
308d39d
Compare
christopherco
changed the title
reubeno
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream Fedora spec wraps the MinGW install steps in a subshell:
Azure Linux does not ship MinGW toolchains, so existing overlays replaced the MinGW macros inside the subshell with empty strings. That left an empty
( )block, which bash rejects withsyntax error near unexpected token ')'when %install runs, failing the build.Change the MinGW
%buildand%installoverlays to substitute the bash no-op:instead of an empty string. The subshell stays syntactically valid and the macros become true no-ops at runtime.Fixes: AB#20285