fix(webkitgtk): drop vestigial gstreamer-plugins-bad BR#17419
Merged
Conversation
gstreamer1-plugins-bad-free is not shipped in AZL, so the hard BuildRequires on pkgconfig(gstreamer-plugins-bad-1.0) caused dnf builddep to fail during chroot init. The BR is vestigial in the upstream Fedora spec: under default cmake options the WebKitGTK 2.50 sources do not #include any gst-plugins-bad headers (gst-bad headers are only reached via GSTREAMER_MPEGTS / GSTREAMER_WEBRTC / LIBWEBRTC, all of which default OFF for the GTK port). Removing the BR alone unblocks the build without changing any runtime feature surface.
2249a9b to
9c77e19
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unnecessary pkgconfig(gstreamer-plugins-bad-1.0) BuildRequires from the WebKitGTK component to unblock dnf builddep/chroot initialization on Azure Linux, where gstreamer1-plugins-bad-free (and thus its pkgconfig() provider) is not shipped.
Changes:
- Dropped the
pkgconfig(gstreamer-plugins-bad-1.0)BuildRequiresfrom the rendered WebKitGTK spec. - Added a corresponding
spec-remove-tagoverlay inwebkitgtk.comp.tomldocumenting why the dependency is vestigial under default CMake options. - Updated the component lock input fingerprint and the rendered spec’s rpmautospec changelog/release.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| specs/w/webkitgtk/webkitgtk.spec | Removes the gstreamer-plugins-bad BuildRequires and updates rpmautospec release/changelog accordingly. |
| locks/webkitgtk.lock | Updates input-fingerprint to reflect the component definition change. |
| base/comps/webkitgtk/webkitgtk.comp.toml | Adds an overlay to remove the vestigial gstreamer-plugins-bad BuildRequires with supporting rationale. |
reubeno
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gstreamer1-plugins-bad-free is not shipped in AZL, so the hard
BuildRequires on pkgconfig(gstreamer-plugins-bad-1.0) caused dnf
builddep to fail during chroot init. The BR is vestigial in the
upstream Fedora spec: under default cmake options the WebKitGTK 2.50
sources do not #include any gst-plugins-bad headers (gst-bad headers
are only reached via GSTREAMER_MPEGTS / GSTREAMER_WEBRTC / LIBWEBRTC,
all of which default OFF for the GTK port). Removing the BR alone
unblocks the build without changing any runtime feature surface.
Fixes: AB#20292