Skip to content

fix(webkitgtk): drop vestigial gstreamer-plugins-bad BR#17419

Merged
reubeno merged 1 commit into
4.0from
chrco/fix-webkitgtk
May 26, 2026
Merged

fix(webkitgtk): drop vestigial gstreamer-plugins-bad BR#17419
reubeno merged 1 commit into
4.0from
chrco/fix-webkitgtk

Conversation

@christopherco
Copy link
Copy Markdown
Collaborator

@christopherco christopherco commented May 24, 2026

gstreamer1-plugins-bad-free is not shipped in AZL, so the hard
BuildRequires on pkgconfig(gstreamer-plugins-bad-1.0) caused dnf
builddep to fail during chroot init. The BR is vestigial in the
upstream Fedora spec: under default cmake options the WebKitGTK 2.50
sources do not #include any gst-plugins-bad headers (gst-bad headers
are only reached via GSTREAMER_MPEGTS / GSTREAMER_WEBRTC / LIBWEBRTC,
all of which default OFF for the GTK port). Removing the BR alone
unblocks the build without changing any runtime feature surface.

Fixes: AB#20292

gstreamer1-plugins-bad-free is not shipped in AZL, so the hard
BuildRequires on pkgconfig(gstreamer-plugins-bad-1.0) caused dnf
builddep to fail during chroot init. The BR is vestigial in the
upstream Fedora spec: under default cmake options the WebKitGTK 2.50
sources do not #include any gst-plugins-bad headers (gst-bad headers
are only reached via GSTREAMER_MPEGTS / GSTREAMER_WEBRTC / LIBWEBRTC,
all of which default OFF for the GTK port). Removing the BR alone
unblocks the build without changing any runtime feature surface.
@christopherco christopherco force-pushed the chrco/fix-webkitgtk branch from 2249a9b to 9c77e19 Compare May 24, 2026 07:50
@christopherco christopherco changed the title fix(webkitgtk): drop gstreamer-plugins-bad BR, disable MSE/EME fix(webkitgtk): drop vestigial gstreamer-plugins-bad BR May 24, 2026
@christopherco christopherco marked this pull request as ready for review May 24, 2026 22:53
Copilot AI review requested due to automatic review settings May 24, 2026 22:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unnecessary pkgconfig(gstreamer-plugins-bad-1.0) BuildRequires from the WebKitGTK component to unblock dnf builddep/chroot initialization on Azure Linux, where gstreamer1-plugins-bad-free (and thus its pkgconfig() provider) is not shipped.

Changes:

  • Dropped the pkgconfig(gstreamer-plugins-bad-1.0) BuildRequires from the rendered WebKitGTK spec.
  • Added a corresponding spec-remove-tag overlay in webkitgtk.comp.toml documenting why the dependency is vestigial under default CMake options.
  • Updated the component lock input fingerprint and the rendered spec’s rpmautospec changelog/release.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
specs/w/webkitgtk/webkitgtk.spec Removes the gstreamer-plugins-bad BuildRequires and updates rpmautospec release/changelog accordingly.
locks/webkitgtk.lock Updates input-fingerprint to reflect the component definition change.
base/comps/webkitgtk/webkitgtk.comp.toml Adds an overlay to remove the vestigial gstreamer-plugins-bad BuildRequires with supporting rationale.

@reubeno reubeno merged commit 5a2f2ec into 4.0 May 26, 2026
12 checks passed
@reubeno reubeno deleted the chrco/fix-webkitgtk branch May 26, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants