fix(qdbm): disable Java bindings#17513
Open
binujp wants to merge 1 commit into
Open
Conversation
AZL does not ship java21-openjdk. Override %java_arches to 'noarch' via build.defines so all %ifarch %java_arches blocks are skipped, cleanly disabling the qdbm-java and qdbm-javadoc subpackages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to disable qdbm’s Java bindings in Azure Linux by overriding the %java_arches macro via component build defines, thereby avoiding Java build dependencies and skipping Java subpackage output. It also moves qdbm from an inline component entry to a dedicated qdbm.comp.toml, updating the lock and rendered spec artifacts accordingly.
Changes:
- Add
base/comps/qdbm/qdbm.comp.tomlwithbuild.definesto overridejava_arches. - Remove the inline
[components.qdbm]entry frombase/comps/components.tomlso the dedicated comp file owns the component config. - Update rendered qdbm spec output (macro load + Source9999 + Release bump) and refresh
locks/qdbm.lockfingerprint.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| specs/q/qdbm/qdbm.spec | Loads generated macros file and adds Source9999; rendered Release bump. |
| specs/q/qdbm/qdbm.azl.macros | Defines %java_arches override used by the rendered spec. |
| locks/qdbm.lock | Updates input fingerprint to reflect component definition change. |
| base/comps/qdbm/qdbm.comp.toml | Introduces qdbm component build define override intended to disable Java bits. |
| base/comps/components.toml | Removes inline qdbm entry now that a dedicated comp.toml exists. |
Comment on lines
+4
to
+6
| # All Azure Linux specs with overlays include this macro file, irrespective of whether new macros have been added. | ||
| %{load:%{_sourcedir}/qdbm.azl.macros} | ||
|
|
| @@ -0,0 +1,5 @@ | |||
| # AZL does not ship java21-openjdk — disable Java bindings. | |||
| # The spec gates all Java support on %ifarch %java_arches, so redefining | |||
| # that macro to an impossible arch disables it cleanly. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable Java bindings in qdbm by setting
java_arches = "noarch"in build defines. This prevents the Java subpackages (qdbm-java, qdbm-javadoc) from being built on real architectures.Rationale
Changes
base/comps/qdbm/qdbm.comp.tomlwithbuild.defines = { java_arches = "noarch" }components.tomlto dedicated comp.tomlTesting