feat(grubby): provide the /etc/sysconfig/kernel file#17532
Conversation
This file has a setting, UPDATEDEFAULT=, which is used by the kernel-install (aka installkernel) program to determine if the default kernel should be updated to use the newly installed kernel. This sets UPDATEDEFAULT=yes, so a newly installed kernel will be set as the default kernel (on the next boot); without this, the default kernel will remain set to the current kernel. Taken from upstream: https://src.fedoraproject.org/rpms/grubby/c/482a2825c47c4fd28a18beb279a3e826461bf878 Fixes: AB#20392
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an /etc/sysconfig/kernel configuration file to the grubby package/component so kernel-install can set defaults consistently.
Changes:
- Add a
kernel.sysconfigfile definingUPDATEDEFAULTandDEFAULTKERNEL. - Update
grubby.specto ship/etc/sysconfig/kernelas%config(noreplace). - Add a
grubbycomponent overlay definition (and adjust component indexing/lock fingerprint).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| specs/g/grubby/kernel.sysconfig | Adds the sysconfig file content to be shipped with the RPM. |
| specs/g/grubby/grubby.spec | Adds Source999, installs the sysconfig file, and marks it as config. |
| locks/grubby.lock | Updates input fingerprint to reflect content changes. |
| base/comps/grubby/kernel.sysconfig | Adds the same sysconfig file content for the component overlay system. |
| base/comps/grubby/grubby.comp.toml | Defines overlays to add the sysconfig file and patch the spec. |
| base/comps/components.toml | Removes the components.grubby entry from the central component list. |
|
verified this does fix the kernel default update behavior: verifying issue exists, on a fresh install of azl4 beta from marketplace: $ sudo grubby --default-kernel verifying issue fixed, on a fresh install of azl4 beta from marketplace: (First, scp patched grubby rpm to system) $ sudo grubby --default-kernel |
|
closing this in favor of updating grubby to f44 version with this change |
This file has a setting, UPDATEDEFAULT=, which is used by the kernel-install (aka installkernel) program to determine if the default kernel should be updated to use the newly installed kernel.
This sets UPDATEDEFAULT=yes, so a newly installed kernel will be set as the default kernel (on the next boot); without this, the default kernel will remain set to the current kernel.
Taken from upstream:
https://src.fedoraproject.org/rpms/grubby/c/482a2825c47c4fd28a18beb279a3e826461bf878
Fixes: AB#20392