Skip to content

fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure#17560

Open
WithEnoughCoffee wants to merge 1 commit into
microsoft:4.0from
WithEnoughCoffee:fix/python-build-br-unresolvable
Open

fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure#17560
WithEnoughCoffee wants to merge 1 commit into
microsoft:4.0from
WithEnoughCoffee:fix/python-build-br-unresolvable

Conversation

@WithEnoughCoffee
Copy link
Copy Markdown
Contributor

@WithEnoughCoffee WithEnoughCoffee commented May 29, 2026

Summary

Disables the tests and extras bconds for python-build to fix BR-unresolvable failures in the Koji nightly build (task 2593995).

Root Cause

The tests bcond (enabled by default when %rhel is undefined) causes %pyproject_buildrequires -g test to generate dynamic BuildRequires for test dependencies (filelock, pytest-mock, setuptools_scm, etc.) that may not be published in the Koji build tag at build time, resulting in mock exit status 30.

Fix

Add build.without = ["extras", "tests"] — aligning with RHEL behavior as the spec was designed for. The %pyproject_check_import basic sanity check still runs.

Testing

  • Local build succeeds (no test BRs pulled in)
  • Smoke-test: pyproject-build --versionbuild 1.3.0
  • Python imports (build, ProjectBuilder, DefaultIsolatedEnv) all work ✓

References

  • Fixes: Koji task 2593995
  • Related: AB#20330

The tests bcond (enabled by default when %rhel is undefined) causes
%pyproject_buildrequires -g test to generate dynamic BuildRequires for
test dependencies (filelock, pytest-mock, setuptools_scm, etc.) that
may not be published in the Koji build tag at build time, resulting in
mock exit status 30 (BR-unresolvable).

Disable tests and extras via build.without, aligning with RHEL behavior
as the spec was designed for. The %pyproject_check_import basic sanity
check still runs.

Fixes: Koji task 2593995
Related: AB#20330
@WithEnoughCoffee WithEnoughCoffee force-pushed the fix/python-build-br-unresolvable branch from c438370 to efa7560 Compare May 29, 2026 21:47
@WithEnoughCoffee WithEnoughCoffee changed the title python-build: disable tests bcond to fix BR-unresolvable nightly failure fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure May 29, 2026
@WithEnoughCoffee WithEnoughCoffee marked this pull request as ready for review May 29, 2026 22:05
Copilot AI review requested due to automatic review settings May 29, 2026 22:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables extras and tests build conditionals for the python-build component to avoid dynamically generated test/extra BuildRequires that can be missing from the Koji nightly tag, while retaining a basic %pyproject_check_import sanity check.

Changes:

  • Add build.without = ["extras", "tests"] for python-build via a dedicated component definition file.
  • Re-render python-build spec output to include the generated .azl.macros file and updated rpmautospec release/changelog.
  • Update the python-build lock input fingerprint to match the new component configuration, and remove python-build from the “unmodified inline” component list.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
base/comps/python-build/python-build.comp.toml Adds component build configuration to disable extras/tests bconds with rationale.
base/comps/components.toml Removes python-build from the inline “unmodified” component list since it’s now customized.
locks/python-build.lock Updates input-fingerprint to reflect the new component config inputs.
specs/p/python-build/python-build.spec Rendered spec updated to load generated macros, add Source9999, and bump release/changelog.
specs/p/python-build/python-build.azl.macros Generated macros file defining %_without_extras and %_without_tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants