Fix C4874 assignment-as-condition in Grapher.cpp - Refactored line 376 to extract assignment before condition check - Resolves C2220/C4874 build error - Fixes cascading build failures - Solution builds with 0 errors - Includes project retargeting to v145

Author: michaelbprice

.github/upgrades/scenarios/cppbuildtoolsupgrade_01921b/assessment.md

@@ -0,0 +1,216 @@
+# C++ Build Tools Upgrade - Assessment Report
+
+**Solution:** C:\Projects\oss\calculator\src\Calculator.sln  
+**Platform Toolset:** v145  
+**Windows SDK:** 10.0.26100.0  
+**Date:** Generated during initial assessment  
+**Total Issues:** 3 errors, 7 warnings across 6 projects
+
+---
+
+## Executive Summary
+
+The solution has been retargeted to the latest Visual Studio build tools (v145), which has introduced new compiler warnings and exposed compatibility issues. The main issues are:
+
+1. **Deprecated `/await` flag** - 5 projects use the deprecated `/await` flag for coroutine support
+2. **C4874 Warning treated as error** - New warning about assignment used as condition in Grapher.cpp
+3. **Cascading build failure** - GraphControl project fails to build, causing downstream projects to fail
+
+---
+
+## In-Scope Issues
+
+These issues are directly related to the build tools upgrade and should be addressed:
+
+### 1. Deprecated `/await` Compiler Flag (5 warnings)
+
+**Warning Code:** D9047  
+**Message:** "option 'await' has been deprecated and will be removed in a future release"
+
+**Affected Projects:**
+- C:\Projects\oss\calculator\src\TraceLogging\TraceLogging.vcxproj (Build order: 1)
+- C:\Projects\oss\calculator\src\CalcManager\CalcManager.vcxproj (Build order: 3)
+- C:\Projects\oss\calculator\src\GraphControl\GraphControl.vcxproj (Build order: 6)
+- C:\Projects\oss\calculator\src\CalcViewModel\CalcViewModel.vcxproj (Build order: 7)
+- C:\Projects\oss\calculator\src\CalcViewModelCopyForUT\CalcViewModelCopyForUT.vcxproj (Build order: 8)
+- C:\Projects\oss\calculator\src\CalculatorUnitTests\CalculatorUnitTests.vcxproj (Build order: 9)
+
+**Analysis:**
+- All projects are using `/std:c++17` with C++/CX (`/ZW` or `/ZW:nostdlib`)
+- The `/await` flag enables coroutine support for C++17, but is deprecated
+- Modern alternatives:
+  - `/await:strict` - Standard-compliant coroutines (requires code changes to remove non-standard extensions)
+  - Upgrade to C++20 with `/std:c++20` or newer (incompatible with `/ZW` C++/CX flag)
+
+**Constraints:**
+- Solution uses C++/CX language extension (`/ZW` or `/ZW:nostdlib` flags present)
+- C++/CX is not compatible with C++20 or newer standards
+- Migration to C++20 would require removing C++/CX and refactoring to WinRT C++/WinRT
+- `/await:strict` requires refactoring code to remove non-standard extensions
+
+---
+
+### 2. C4874 Warning - Assignment Used as Condition (1 error, 1 warning)
+
+**Error Code:** C2220  
+**Message:** "the following warning is treated as an error"
+
+**Warning Code:** C4874  
+**Message:** "assignment used as a condition"
+
+**Affected File:**
+- C:\Projects\oss\calculator\src\GraphControl\Control\Grapher.cpp (376, 33)
+
+**Project:**
+- C:\Projects\oss\calculator\src\GraphControl\GraphControl.vcxproj (Build order: 6)
+
+**Analysis:**
+The newer compiler has introduced a new warning C4874 that flags assignment expressions used as conditions. Since the project compiles with `/WX` (treat warnings as errors), this causes a build failure.
+
+**Root Cause:**
+Line 376, column 33 in Grapher.cpp has code like: `if (x = y)` instead of `if (x == y)` or `if ((x = y))`
+
+**Resolution Options:**
+1. Fix the code by enclosing assignment in parentheses: `if ((x = y))` - indicates intentional assignment
+2. Change to comparison if it's a bug: `if (x == y)`
+3. Temporarily use `/Wv:18` flag to revert to previous compiler warning behavior (not recommended)
+
+**Impact:** This is a **blocking error** that prevents GraphControl.dll from building, causing cascading failures.
+
+---
+
+### 3. Cascading Build Failures (2 errors)
+
+#### 3a. GraphControl WinMD Missing
+**Error Code:** C1192  
+**Message:** "#using failed on 'C:\Projects\oss\calculator\src\x64\Debug\GraphControl\GraphControl.winmd'"
+
+**Affected File:**
+- C:\Projects\oss\calculator\src\CalcViewModel\pch.cpp
+
+**Project:**
+- C:\Projects\oss\calculator\src\CalcViewModel\CalcViewModel.vcxproj (Build order: 7)
+
+**Analysis:**
+This error occurs because GraphControl.dll failed to build (due to C4874 error), so GraphControl.winmd was not generated. CalcViewModel depends on GraphControl and tries to reference the WinMD file in its precompiled header.
+
+**Resolution:** Fix issue #2 (C4874 error) first, which will allow GraphControl to build successfully and generate the WinMD file.
+
+---
+
+#### 3b. CalcViewModelCopyForUT Library Missing
+**Error Code:** LNK1181  
+**Message:** "cannot open input file 'C:\Projects\oss\calculator\src\x64\Debug\CalcViewModelCopyForUT\CalcViewModelCopyForUT.lib'"
+
+**Project:**
+- C:\Projects\oss\calculator\src\CalculatorUnitTests\CalculatorUnitTests.vcxproj (Build order: 9)
+
+**Analysis:**
+This is also a cascading error. CalcViewModelCopyForUT.lib was not built because:
+1. GraphControl failed to build (C4874 error)
+2. CalcViewModel failed to build (missing GraphControl.winmd)
+3. CalcViewModelCopyForUT likely depends on GraphControl and failed to build
+4. CalculatorUnitTests cannot link without CalcViewModelCopyForUT.lib
+
+**Resolution:** Fix issue #2 (C4874 error) first, which should resolve the entire cascade.
+
+---
+
+## Out-of-Scope Issues
+
+These issues are not related to the build tools upgrade:
+
+*None identified* - All current errors and warnings are related to the build tools upgrade.
+
+---
+
+## Dependency Analysis
+
+**Build Order & Dependencies:**
+1. TraceLogging (Build order 1) - Has deprecated `/await` warning
+2. CalcManager (Build order 3) - Has deprecated `/await` warning
+3. **GraphControl (Build order 6)** - **BLOCKED by C4874 error** - Has deprecated `/await` warning
+4. CalcViewModel (Build order 7) - Depends on GraphControl, blocked by cascading error
+5. CalcViewModelCopyForUT (Build order 8) - Depends on GraphControl, likely blocked
+6. CalculatorUnitTests (Build order 9) - Depends on CalcViewModelCopyForUT, blocked by cascading error
+
+**Critical Path:**
+Fix GraphControl.cpp C4874 error → Unblocks CalcViewModel → Unblocks CalcViewModelCopyForUT → Unblocks CalculatorUnitTests
+
+---
+
+## Recommended Approach
+
+### Priority 1: Unblock Build (Required)
+**Fix C4874 warning in Grapher.cpp** - This is the only blocking error preventing the entire solution from building.
+
+### Priority 2: Address Deprecated `/await` Flag
+Since the solution uses C++/CX and C++17, we have limited options:
+
+**Option A: Suppress the warning temporarily** (Least effort, temporary solution)
+- Keep `/await` and `/std:c++17`
+- Accept that the warning will remain until `/await` is removed by Microsoft
+- Minimal code changes
+
+**Option B: Switch to `/await:strict`** (Moderate effort, better compatibility)
+- Replace `/await` with `/await:strict` in all affected projects
+- Requires code review to identify and fix non-standard coroutine extensions
+- Keeps C++17 and C++/CX compatibility
+- More future-proof than Option A
+
+**Option C: Migrate to C++20 without C++/CX** (High effort, most modern)
+- Remove `/ZW` flags and migrate from C++/CX to C++/WinRT
+- Upgrade to `/std:c++20` or `/std:c++latest`
+- Remove `/await` flag (C++20 has native coroutine support)
+- Requires significant code refactoring across the entire solution
+- Most future-proof solution
+
+---
+
+## Impact Assessment
+
+**Current State:**
+- ❌ Solution does NOT build
+- ❌ 3 errors block 4 projects
+- ⚠️ 7 warnings from deprecated flags
+
+**After Priority 1 Fix (C4874):**
+- ✅ Solution builds successfully
+- ⚠️ 5-6 warnings remain from deprecated `/await` flag
+
+**After Priority 2 Fix (Deprecated `/await`):**
+- ✅ Solution builds successfully
+- ✅ No build tools upgrade warnings
+
+---
+
+## Estimated Effort
+
+| Priority | Issue | Effort | Risk |
+|----------|-------|--------|------|
+| P1 | Fix C4874 in Grapher.cpp | Low (1 line fix) | Low |
+| P2-A | Suppress `/await` warning | Low (update project settings) | Low (temporary) |
+| P2-B | Migrate to `/await:strict` | Medium (code review + fixes) | Medium |
+| P2-C | Migrate to C++20 + C++/WinRT | High (full refactor) | High |
+
+---
+
+## Next Steps
+
+1. **Review this assessment** - Confirm the issues identified match expectations
+2. **Choose approach for deprecated `/await` flag** - Select Option A, B, or C based on:
+   - Timeline and resources available
+   - Long-term maintenance goals
+   - Whether C++/CX to C++/WinRT migration is planned
+3. **Proceed to Planning Stage** - Generate detailed plan for chosen approach
+
+---
+
+## Questions for Decision Making
+
+1. **Immediate Goal:** Do you want to just unblock the build (Priority 1 only), or address all warnings?
+2. **Long-term Strategy:** Is migrating away from C++/CX to C++/WinRT on the roadmap?
+3. **Timeline:** How much time is available for this upgrade?
+4. **Code Review:** Are there resources available to review coroutine usage if switching to `/await:strict`?
+
+Please review this assessment and let me know which issues you would like me to address and which approach you prefer for the deprecated `/await` flag.

.github/upgrades/scenarios/cppbuildtoolsupgrade_01921b/execution-log.md

@@ -0,0 +1,13 @@
+
+## [2026-01-27 10:38] TASK-001: Verify prerequisites
+
+Status: Complete
+
+- **Verified**: 
+  - Visual Studio build tools v145 is installed and accessible (confirmed from assessment rebuild)
+  - Windows SDK 10.0.26100.0 is installed (confirmed from assessment rebuild)
+  - Solution C:\Projects\oss\calculator\src\Calculator.sln loads successfully
+  - Current branch: main with pending changes (project retargeting)
+
+Success - All prerequisites verified and ready for execution.
+