PS: Add a test demonstraing missing arguments for object creations.

Author: MathiasVP

powershell/ql/test/library-tests/controlflow/elements.expected

@@ -1,2 +1,5 @@
+forEach
 | graph/functions.ps1:29:5:32:5 | forach(... in ...) | graph/functions.ps1:29:14:29:20 | number | graph/functions.ps1:29:25:29:32 | numbers | graph/functions.ps1:29:35:32:5 | {...} |
 | graph/loops.ps1:52:5:55:5 | forach(... in ...) | graph/loops.ps1:52:14:52:20 | letter | graph/loops.ps1:52:25:52:36 | letterArray | graph/loops.ps1:53:5:55:5 | {...} |
+objectCreation
+| graph/exprs.ps1:2:10:2:91 | Call to new-object | 0 | graph/exprs.ps1:2:21:2:71 | Microsoft.Data.SqlClient.SqlConnectionStringBuilder |

powershell/ql/test/library-tests/controlflow/elements.ql

@@ -6,4 +6,8 @@ query predicate forEach(ForEachStmtCfgNode forEach, ExprCfgNode va, ExprCfgNode
   va = forEach.getVarAccess() and
   iterable = forEach.getIterableExpr() and
   body = forEach.getBody()
+}
+
+query predicate objectCreation(ObjectCreationCfgNode oc, int i, ExprCfgNode argument) {
+  argument = oc.getArgument(i)
 }

powershell/ql/test/library-tests/controlflow/graph/Cfg.expected

@@ -218,6 +218,22 @@
 | conditionals.ps1:124:5:124:6 | a | conditionals.ps1:123:33:129:1 | exit {...} (normal) |  |
 | conditionals.ps1:124:5:128:5 | ...=... | conditionals.ps1:124:5:124:6 | a |  |
 | conditionals.ps1:124:5:128:5 | {...} | conditionals.ps1:124:5:128:5 | ...=... |  |
+| exprs.ps1:1:1:3:1 | def of objectCreation | exprs.ps1:1:1:3:1 | exit {...} (normal) |  |
+| exprs.ps1:1:1:3:1 | enter {...} | exprs.ps1:1:1:3:1 | {...} |  |
+| exprs.ps1:1:1:3:1 | exit {...} (normal) | exprs.ps1:1:1:3:1 | exit {...} |  |
+| exprs.ps1:1:1:3:1 | {...} | exprs.ps1:1:1:3:1 | def of objectCreation |  |
+| exprs.ps1:1:1:3:1 | {...} | exprs.ps1:1:1:3:1 | {...} |  |
+| exprs.ps1:1:25:3:1 | [synth] pipeline | exprs.ps1:2:5:2:91 | {...} |  |
+| exprs.ps1:1:25:3:1 | enter {...} | exprs.ps1:1:25:3:1 | {...} |  |
+| exprs.ps1:1:25:3:1 | exit {...} (normal) | exprs.ps1:1:25:3:1 | exit {...} |  |
+| exprs.ps1:1:25:3:1 | {...} | exprs.ps1:1:25:3:1 | [synth] pipeline |  |
+| exprs.ps1:2:5:2:6 | x | exprs.ps1:2:10:2:19 | New-Object |  |
+| exprs.ps1:2:5:2:91 | ...=... | exprs.ps1:2:5:2:6 | x |  |
+| exprs.ps1:2:5:2:91 | {...} | exprs.ps1:2:5:2:91 | ...=... |  |
+| exprs.ps1:2:10:2:19 | New-Object | exprs.ps1:2:21:2:71 | Microsoft.Data.SqlClient.SqlConnectionStringBuilder |  |
+| exprs.ps1:2:10:2:91 | Call to new-object | exprs.ps1:1:25:3:1 | exit {...} (normal) |  |
+| exprs.ps1:2:21:2:71 | Microsoft.Data.SqlClient.SqlConnectionStringBuilder | exprs.ps1:2:87:2:91 | arg |  |
+| exprs.ps1:2:87:2:91 | arg | exprs.ps1:2:10:2:91 | Call to new-object |  |
 | functions.ps1:1:1:9:1 | def of Add-Numbers-Arguments | functions.ps1:11:1:11:28 | def of foo |  |
 | functions.ps1:1:1:52:1 | {...} | functions.ps1:1:1:9:1 | def of Add-Numbers-Arguments |  |
 | functions.ps1:1:1:54:0 | enter {...} | functions.ps1:1:1:54:0 | {...} |  |

powershell/ql/test/library-tests/controlflow/graph/exprs.ps1

@@ -0,0 +1,3 @@
+function objectCreation {
+    $x = New-Object Microsoft.Data.SqlClient.SqlConnectionStringBuilder -ArgumentList "arg"
+}