Skip to content

Update condition for Mariner and Azure Linux installation for artifacts-helper #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ms-nateb wants to merge 2 commits into from
Closed

Update condition for Mariner and Azure Linux installation for artifacts-helper #105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e9a7b5
Update condition for Mariner and Azure Linux installation
ms-nateb Apr 1, 2026
b81bd04
Update conditional syntax in install.sh
ms-nateb Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/artifacts-helper/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ check_packages() {

export DEBIAN_FRONTEND=noninteractive

if [ "${ID}" = "mariner" ]; then
if [[ "${ID}" == "mariner" || ( "${ID}" == "azurelinux" && "${VERSION_ID}" == "3.0" ) ]]; then
tdnf install -y wget ca-certificates
tdnf clean all
Comment on lines +73 to 75
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds Azure Linux support, but the feature’s stated OS support (see src/artifacts-helper/README.md “OS Support”) currently only mentions Debian/Ubuntu and Mariner. Please update the OS support documentation to include Azure Linux (and any version constraints) so consumers know it’s supported.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@markphip markphip Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot could we just approach this differently and discover the right package manager? We could probe for tdnf and it found use that, otherwise use dpkg?

Copy link
Copy Markdown
Contributor

@markphip markphip Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot could we just approach this differently and discover the right package manager? We could probe for tdnf and it found use that, otherwise use dpkg?

else
Expand Down Expand Up @@ -145,4 +145,4 @@ if [ "${INSTALL_WITH_SUDO}" = "true" ]; then
fi
rm /tmp/install-provider.sh

exit 0
exit 0
Loading