don't report dependencies from .sln files

Author: brettfo

src/Microsoft.ComponentDetection.Detectors/nuget/NuGetMSBuildBinaryLogComponentDetector.cs

@@ -2,6 +2,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using System.Threading;
 using Microsoft.Build.Locator;
@@ -183,6 +184,12 @@ private void ProcessBinLog(Build buildRoot, ISingleFileComponentRecorder compone
         var projectsPerPackage = new Dictionary<string, HashSet<string>>(StringComparer.OrdinalIgnoreCase);
         foreach (var projectPath in projectResolvedDependencies.Keys)
         {
+            if (Path.GetExtension(projectPath).Equals(".sln", StringComparison.OrdinalIgnoreCase))
+            {
+                // don't report solution files
+                continue;
+            }
+
             var projectDependencies = projectResolvedDependencies[projectPath];
             foreach (var (packageName, packageVersion) in projectDependencies)
             {
@@ -198,8 +205,9 @@ private void ProcessBinLog(Build buildRoot, ISingleFileComponentRecorder compone
         }
 
         // report it all
-        foreach (var (packageNameAndVersion, projectPaths) in projectsPerPackage)
+        foreach (var packageNameAndVersion in projectsPerPackage.Keys.OrderBy(p => p))
         {
+            var projectPaths = projectsPerPackage[packageNameAndVersion];
             var parts = packageNameAndVersion.Split('/', 2);
             var packageName = parts[0];
             var packageVersion = parts[1];

test/Microsoft.ComponentDetection.Detectors.Tests/NuGetMSBuildBinaryLogComponentDetectorTests.cs

@@ -196,6 +196,14 @@ public async Task PackagesReportedFromSeparateProjectsDoNotOverlap()
             .OrderBy(c => c.Name)
             .Select(c => $"{c.Name}/{c.Version}");
         project2Components.Should().Equal("Package.B/4.5.6");
+
+        var solutionComponents = detectedComponents
+            .Where(d => d.FilePaths.Any(p => p.Replace("\\", "/").EndsWith("/solution.sln")))
+            .Select(d => d.Component)
+            .Cast<NuGetComponent>()
+            .OrderBy(c => c.Name)
+            .Select(c => $"{c.Name}/{c.Version}");
+        solutionComponents.Should().BeEmpty();
     }
 
     private async Task<(IndividualDetectorScanResult ScanResult, IComponentRecorder ComponentRecorder)> ExecuteDetectorAndGetBinLogAsync(