Skip to content

Commit 3fc9d88

Browse files
Merge pull request #854 from microsoft/sfi-issueFix
fix: SFI issue fixes
2 parents cd15408 + 95de97a commit 3fc9d88

3 files changed

Lines changed: 13 additions & 10 deletions

File tree

infra/main.bicep

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,7 @@ module jumpboxVM 'br/public:avm/res/compute/virtual-machine:0.21.0' = if (deploy
494494

495495
// ========== Data Collection Rule for Jumpbox Security Event Logs (SFI-AzTBv17) ========== //
496496
var jumpboxDcrName = take('dcr-${jumpboxVmName}', 64)
497+
var dcrLogAnalyticsDestinationName = 'la-${logAnalyticsWorkspaceResourceName}-destination'
497498
module jumpboxDcr 'br/public:avm/res/insights/data-collection-rule:0.11.0' = if (deployAdminAccessResources && enableMonitoring) {
498499
name: take('avm.res.insights.data-collection-rule.${jumpboxDcrName}', 64)
499500
params: {
@@ -512,15 +513,15 @@ module jumpboxDcr 'br/public:avm/res/insights/data-collection-rule:0.11.0' = if
512513
'Microsoft-SecurityEvent'
513514
]
514515
xPathQueries: [
515-
'Security!*[System[(band(Keywords,13510798882111488))]]'
516+
'Security!*[System[(band(Keywords,13510798882111488)) and (EventID != 4624)]]'
516517
]
517518
}
518519
]
519520
}
520521
destinations: {
521522
logAnalytics: [
522523
{
523-
name: 'laDestination'
524+
name: dcrLogAnalyticsDestinationName
524525
workspaceResourceId: logAnalyticsWorkspaceResourceId
525526
}
526527
]
@@ -531,7 +532,7 @@ module jumpboxDcr 'br/public:avm/res/insights/data-collection-rule:0.11.0' = if
531532
'Microsoft-SecurityEvent'
532533
]
533534
destinations: [
534-
'laDestination'
535+
dcrLogAnalyticsDestinationName
535536
]
536537
}
537538
]

infra/main.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"_generator": {
77
"name": "bicep",
88
"version": "0.43.8.12551",
9-
"templateHash": "14282475649019624593"
9+
"templateHash": "11476101976733556609"
1010
},
1111
"name": "Intelligent Content Generation Accelerator",
1212
"description": "Solution Accelerator for multimodal marketing content generation using Microsoft Agent Framework.\n"
@@ -354,6 +354,7 @@
354354
"jumpboxUniqueToken": "[take(uniqueString(resourceGroup().id, variables('solutionSuffix')), 10)]",
355355
"jumpboxVmName": "[take(format('vm-{0}', variables('jumpboxUniqueToken')), 15)]",
356356
"jumpboxDcrName": "[take(format('dcr-{0}', variables('jumpboxVmName')), 64)]",
357+
"dcrLogAnalyticsDestinationName": "[format('la-{0}-destination', variables('logAnalyticsWorkspaceResourceName'))]",
357358
"privateDnsZones": [
358359
"privatelink.cognitiveservices.azure.com",
359360
"privatelink.openai.azure.com",
@@ -18302,15 +18303,15 @@
1830218303
"Microsoft-SecurityEvent"
1830318304
],
1830418305
"xPathQueries": [
18305-
"Security!*[System[(band(Keywords,13510798882111488))]]"
18306+
"Security!*[System[(band(Keywords,13510798882111488)) and (EventID != 4624)]]"
1830618307
]
1830718308
}
1830818309
]
1830918310
},
1831018311
"destinations": {
1831118312
"logAnalytics": [
1831218313
{
18313-
"name": "laDestination",
18314+
"name": "[variables('dcrLogAnalyticsDestinationName')]",
1831418315
"workspaceResourceId": "[if(variables('useExistingLogAnalytics'), parameters('existingLogAnalyticsWorkspaceId'), if(parameters('enableMonitoring'), reference('logAnalyticsWorkspace').outputs.resourceId.value, ''))]"
1831518316
}
1831618317
]
@@ -18321,7 +18322,7 @@
1832118322
"Microsoft-SecurityEvent"
1832218323
],
1832318324
"destinations": [
18324-
"laDestination"
18325+
"[variables('dcrLogAnalyticsDestinationName')]"
1832518326
]
1832618327
}
1832718328
]

infra/main_custom.bicep

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -520,6 +520,7 @@ module jumpboxVM 'br/public:avm/res/compute/virtual-machine:0.21.0' = if (deploy
520520

521521
// ========== Data Collection Rule for Jumpbox Security Event Logs (SFI-AzTBv17) ========== //
522522
var jumpboxDcrName = take('dcr-${jumpboxVmName}', 64)
523+
var dcrLogAnalyticsDestinationName = 'la-${logAnalyticsWorkspaceResourceName}-destination'
523524
module jumpboxDcr 'br/public:avm/res/insights/data-collection-rule:0.11.0' = if (deployAdminAccessResources && enableMonitoring) {
524525
name: take('avm.res.insights.data-collection-rule.${jumpboxDcrName}', 64)
525526
params: {
@@ -538,15 +539,15 @@ module jumpboxDcr 'br/public:avm/res/insights/data-collection-rule:0.11.0' = if
538539
'Microsoft-SecurityEvent'
539540
]
540541
xPathQueries: [
541-
'Security!*[System[(band(Keywords,13510798882111488))]]'
542+
'Security!*[System[(band(Keywords,13510798882111488)) and (EventID != 4624)]]'
542543
]
543544
}
544545
]
545546
}
546547
destinations: {
547548
logAnalytics: [
548549
{
549-
name: 'laDestination'
550+
name: dcrLogAnalyticsDestinationName
550551
workspaceResourceId: logAnalyticsWorkspaceResourceId
551552
}
552553
]
@@ -557,7 +558,7 @@ module jumpboxDcr 'br/public:avm/res/insights/data-collection-rule:0.11.0' = if
557558
'Microsoft-SecurityEvent'
558559
]
559560
destinations: [
560-
'laDestination'
561+
dcrLogAnalyticsDestinationName
561562
]
562563
}
563564
]

0 commit comments

Comments
 (0)