test file updated

Author: Ragini-Microsoft

src/tests/test_app.py

@@ -85,9 +85,6 @@ async def test_chat_empty_body(client):
     )
 
     assert response.status_code == 400
-    data = await response.get_json()
-    assert data["action_type"] == "error"
-    assert "required" in data["message"].lower()
 
 
 @pytest.mark.asyncio
@@ -103,6 +100,35 @@ async def test_chat_whitespace_message(client):
     assert data["action_type"] == "error"
 
 
+@pytest.mark.asyncio
+async def test_chat_null_message(client):
+    """Test chat endpoint handles null message without crashing."""
+    response = await client.post(
+        "/api/chat",
+        json={"conversation_id": "test-conv", "message": None}
+    )
+
+    assert response.status_code == 400
+    data = await response.get_json()
+    assert data["action_type"] == "error"
+    assert "empty" in data["message"].lower()
+
+
+@pytest.mark.asyncio
+async def test_chat_invalid_json_body(client):
+    """Test chat endpoint rejects invalid JSON body with 400."""
+    response = await client.post(
+        "/api/chat",
+        data="not valid json",
+        headers={"Content-Type": "application/json"}
+    )
+
+    assert response.status_code == 400
+    data = await response.get_json()
+    assert data["action_type"] == "error"
+    assert "required" in data["message"].lower()
+
+
 @pytest.mark.asyncio
 async def test_chat_empty_message_with_action_allowed(client):
     """Test chat endpoint allows empty message when action is specified."""
@@ -229,36 +255,15 @@ async def test_chat_cosmos_failure(client):
 
 @pytest.mark.asyncio
 async def test_parse_brief_missing_text(client):
-    """Test chat endpoint with missing message still processes (no validation)."""
-    with patch("app.get_routing_service") as mock_routing, \
-         patch("app.get_cosmos_service") as mock_cosmos, \
-         patch("app.get_orchestrator") as mock_orch:
-
-        from services.routing_service import Intent, RoutingResult, ConversationState
-        mock_routing_service = MagicMock()
-        mock_routing_service.classify_intent = MagicMock(return_value=RoutingResult(
-            intent=Intent.PARSE_BRIEF,
-            confidence=0.5
-        ))
-        mock_routing_service.derive_state_from_conversation = MagicMock(return_value=ConversationState())
-        mock_routing.return_value = mock_routing_service
-
-        mock_cosmos_service = AsyncMock()
-        mock_cosmos_service.get_conversation = AsyncMock(return_value=None)
-        mock_cosmos_service.add_message_to_conversation = AsyncMock()
-        mock_cosmos.return_value = mock_cosmos_service
-
-        mock_orchestrator = AsyncMock()
-        mock_orchestrator.parse_brief = AsyncMock(return_value=(MagicMock(model_dump=lambda: {}), None, False))
-        mock_orch.return_value = mock_orchestrator
-
-        response = await client.post(
-            "/api/chat",
-            json={"conversation_id": "test-conv"}
-        )
+    """Test chat endpoint rejects missing message with 400."""
+    response = await client.post(
+        "/api/chat",
+        json={"conversation_id": "test-conv"}
+    )
 
-        # API doesn't validate missing message - routes to handler with empty message
-        assert response.status_code in [200, 500]
+    assert response.status_code == 400
+    data = await response.get_json()
+    assert data["action_type"] == "error"
 
 
 @pytest.mark.asyncio
@@ -906,39 +911,17 @@ async def test_regenerate_content_success(client, sample_creative_brief_dict):
 
 @pytest.mark.asyncio
 async def test_regenerate_content_missing_modification_request(client, sample_creative_brief_dict):
-    """Test regeneration without message still routes (no validation)."""
-    with patch("app.get_routing_service") as mock_routing, \
-         patch("app.get_cosmos_service") as mock_cosmos, \
-         patch("app.get_orchestrator") as mock_orch:
-
-        from services.routing_service import Intent, RoutingResult, ConversationState
-        mock_routing_service = MagicMock()
-        mock_routing_service.classify_intent = MagicMock(return_value=RoutingResult(
-            intent=Intent.PARSE_BRIEF,
-            confidence=0.5
-        ))
-        mock_routing_service.derive_state_from_conversation = MagicMock(return_value=ConversationState())
-        mock_routing.return_value = mock_routing_service
-
-        mock_cosmos_service = AsyncMock()
-        mock_cosmos_service.get_conversation = AsyncMock(return_value=None)
-        mock_cosmos_service.add_message_to_conversation = AsyncMock()
-        mock_cosmos.return_value = mock_cosmos_service
-
-        mock_orchestrator = AsyncMock()
-        mock_orchestrator.parse_brief = AsyncMock(return_value=(MagicMock(model_dump=lambda: {}), None, False))
-        mock_orch.return_value = mock_orchestrator
-
-        response = await client.post(
-            "/api/chat",
-            json={
-                "conversation_id": "test-conv"
-                # Missing message - no validation in backend
-            }
-        )
+    """Test regeneration rejects missing message with 400."""
+    response = await client.post(
+        "/api/chat",
+        json={
+            "conversation_id": "test-conv"
+        }
+    )
 
-        # Backend doesn't validate missing message
-        assert response.status_code in [200, 500]
+    assert response.status_code == 400
+    data = await response.get_json()
+    assert data["action_type"] == "error"
 
 
 @pytest.mark.asyncio