Skip to content

fix: update SEND_BUTTON locator to use aria-label for improved accessibility#845

Merged
Avijit-Microsoft merged 2 commits into
devfrom
LogoutFunctionality_Akhileswar
May 11, 2026
Merged

fix: update SEND_BUTTON locator to use aria-label for improved accessibility#845
Avijit-Microsoft merged 2 commits into
devfrom
LogoutFunctionality_Akhileswar

Conversation

@Akhileswara-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request improves the accessibility and reliability of the chat input's send button by adding an aria-label and updating the corresponding end-to-end test locator.

Accessibility improvements:

  • Added aria-label="Send" to the send button in ChatInput, making it more accessible for screen readers.

Test reliability:

  • Updated the SEND_BUTTON locator in HomePage.py to use the new aria-label, ensuring the end-to-end test reliably selects the correct button.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

Other Information

This pull request introduces a small but important accessibility improvement to the chat input component and updates the end-to-end test locator to match. The main changes are:

Accessibility improvement:

  • Added an aria-label="Send" attribute to the send button in ChatInput.tsx to improve accessibility for screen readers.

Test locator update:

  • Updated the SEND_BUTTON locator in HomePage.py to use the new aria-label attribute, making the test more robust and less dependent on button order.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request improves accessibility and test robustness around the chat input “Send” button by adding an accessible name and switching the E2E selector to target that stable attribute.

Changes:

  • Added aria-label="Send" to the send button in ChatInput.tsx.
  • Updated the E2E SEND_BUTTON locator to use the new aria-label instead of a positional XPath.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/App/src/components/ChatInput.tsx Adds an aria-label to the icon-only send button to provide an accessible name.
tests/e2e-test/pages/HomePage.py Updates the Playwright locator to select the send button via aria-label, avoiding brittle positional selectors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Avijit-Microsoft
Avijit-Microsoft merged commit d5b6ceb into dev May 11, 2026
64 of 71 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Akhileswara-Microsoft
Akhileswara-Microsoft deleted the LogoutFunctionality_Akhileswar branch May 21, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants