fix: update SEND_BUTTON locator to use aria-label for improved accessibility#845
Merged
Merged
Conversation
Akhileswara-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
malrose07,
nchandhi and
toherman-msft
as code owners
May 8, 2026 10:12
Akhileswara-Microsoft
temporarily deployed
to
production
May 8, 2026 10:12 — with
GitHub Actions
Inactive
Akhileswara-Microsoft
temporarily deployed
to
production
May 8, 2026 10:13 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves accessibility and test robustness around the chat input “Send” button by adding an accessible name and switching the E2E selector to target that stable attribute.
Changes:
- Added
aria-label="Send"to the send button inChatInput.tsx. - Updated the E2E
SEND_BUTTONlocator to use the newaria-labelinstead of a positional XPath.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/App/src/components/ChatInput.tsx |
Adds an aria-label to the icon-only send button to provide an accessible name. |
tests/e2e-test/pages/HomePage.py |
Updates the Playwright locator to select the send button via aria-label, avoiding brittle positional selectors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Akhileswara-Microsoft
temporarily deployed
to
production
May 8, 2026 10:15 — with
GitHub Actions
Inactive
Akhileswara-Microsoft
temporarily deployed
to
production
May 8, 2026 10:16 — with
GitHub Actions
Inactive
Akhileswara-Microsoft
had a problem deploying
to
production
May 8, 2026 10:16 — with
GitHub Actions
Failure
Akhileswara-Microsoft
temporarily deployed
to
production
May 8, 2026 10:17 — with
GitHub Actions
Inactive
Akhileswara-Microsoft
had a problem deploying
to
production
May 8, 2026 10:18 — with
GitHub Actions
Failure
Akhileswara-Microsoft
temporarily deployed
to
production
May 8, 2026 10:20 — with
GitHub Actions
Inactive
Akhileswara-Microsoft
temporarily deployed
to
production
May 8, 2026 10:34 — with
GitHub Actions
Inactive
Akhileswara-Microsoft
temporarily deployed
to
production
May 8, 2026 10:36 — with
GitHub Actions
Inactive
Akhileswara-Microsoft
had a problem deploying
to
production
May 8, 2026 10:36 — with
GitHub Actions
Error
Ragini-Microsoft
temporarily deployed
to
production
May 8, 2026 11:18 — with
GitHub Actions
Inactive
Ragini-Microsoft
temporarily deployed
to
production
May 8, 2026 11:20 — with
GitHub Actions
Inactive
Ragini-Microsoft
temporarily deployed
to
production
May 8, 2026 11:21 — with
GitHub Actions
Inactive
Ragini-Microsoft
temporarily deployed
to
production
May 8, 2026 11:26 — with
GitHub Actions
Inactive
Ragini-Microsoft
temporarily deployed
to
production
May 8, 2026 11:30 — with
GitHub Actions
Inactive
Avijit-Microsoft
approved these changes
May 11, 2026
Contributor
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request improves the accessibility and reliability of the chat input's send button by adding an
aria-labeland updating the corresponding end-to-end test locator.Accessibility improvements:
aria-label="Send"to the send button inChatInput, making it more accessible for screen readers.Test reliability:
SEND_BUTTONlocator inHomePage.pyto use the newaria-label, ensuring the end-to-end test reliably selects the correct button.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
Other Information
This pull request introduces a small but important accessibility improvement to the chat input component and updates the end-to-end test locator to match. The main changes are:
Accessibility improvement:
aria-label="Send"attribute to the send button inChatInput.tsxto improve accessibility for screen readers.Test locator update:
SEND_BUTTONlocator inHomePage.pyto use the newaria-labelattribute, making the test more robust and less dependent on button order.