fix: Add validation for empty request body and message content in chat handler#846
Merged
Conversation
Ragini-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
malrose07,
nchandhi and
toherman-msft
as code owners
May 12, 2026 07:13
Ragini-Microsoft
temporarily deployed
to
production
May 12, 2026 07:13 — with
GitHub Actions
Inactive
Contributor
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
Ragini-Microsoft
temporarily deployed
to
production
May 12, 2026 07:16 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens input validation for the Quart unified chat endpoint (/api/chat) to reject missing/empty request bodies and empty message content when no action is provided, improving API robustness and error clarity.
Changes:
- Added an early 400 response when the request JSON body is missing/empty.
- Added a 400 response when both
actionis absent andmessageis empty/whitespace.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ragini-Microsoft
temporarily deployed
to
production
May 12, 2026 07:23 — with
GitHub Actions
Inactive
Ragini-Microsoft
temporarily deployed
to
production
May 12, 2026 07:42 — with
GitHub Actions
Inactive
Ragini-Microsoft
temporarily deployed
to
production
May 12, 2026 07:50 — with
GitHub Actions
Inactive
Avijit-Microsoft
approved these changes
May 12, 2026
Contributor
|
🎉 This PR is included in version 2.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds improved input validation to the unified chat endpoint in
app.py. The main changes ensure that the endpoint returns clear error messages for missing or empty request data, which helps prevent processing invalid requests and improves the API's robustness.Input validation improvements:
actionandmessagefields are empty or missing, ensuring that chat requests include meaningful content.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation