Commit b96ad2a
chore: resolve Copilot review comments from PR #579
Addresses three Copilot reviewer comments on PR #579:
- validate-bicep-params.yml: replace hard-coded GitHub.com run URL with
GitHub Actions context (server_url/repository/run_id) so the email
notification links work correctly on GitHub Enterprise Server.
- validate_bicep_params.py: replace the bespoke _html_escape with a thin
wrapper around stdlib html.escape(text, quote=True) so single quotes
are also escaped and the escaping rules stay correct as the template
evolves.
- content_understanding.get_image_from_analyze_operation: tighten the
docstring/return type to reflect that the helper is intentionally
JPEG/image-specific (matches the image_id parameter and the
image/jpeg Content-Type assertion), return Optional[bytes], document
the ValueError/AssertionError it can raise, and switch the failure
branch from print() to the class logger.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 710c300 commit b96ad2a
3 files changed
Lines changed: 35 additions & 20 deletions
File tree
- .github/workflows
- infra/scripts
- src/ContentProcessor/src/libs/azure_helper
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | | - | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
346 | 347 | | |
347 | 348 | | |
348 | 349 | | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | | - | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
356 | 358 | | |
357 | 359 | | |
358 | 360 | | |
| |||
Lines changed: 25 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
294 | 295 | | |
295 | 296 | | |
296 | 297 | | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | | - | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
305 | 309 | | |
306 | 310 | | |
307 | | - | |
308 | | - | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
309 | 315 | | |
310 | | - | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
311 | 324 | | |
312 | 325 | | |
313 | 326 | | |
| |||
326 | 339 | | |
327 | 340 | | |
328 | 341 | | |
329 | | - | |
| 342 | + | |
330 | 343 | | |
331 | 344 | | |
332 | 345 | | |
| |||
0 commit comments