Skip to content

Commit bdb51ba

Browse files
fix: address review comments - event_id collision and nondeterministic file_types
- Pass agent_name and model_deployment_name to emit_summary for unique event_id - Sort file_types set before joining for deterministic telemetry dimensions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent cf487d9 commit bdb51ba

5 files changed

Lines changed: 7 additions & 3 deletions

File tree

src/ContentProcessor/src/libs/llm_token_telemetry.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -773,6 +773,8 @@ def emit_all(
773773
primary_model=model_deployment_name,
774774
additional_agents=additional_agents,
775775
telemetry_overhead_ms=f"{batch_overhead_ms:.3f}",
776+
agent_name=agent_name,
777+
model_deployment_name=model_deployment_name,
776778
**dimensions,
777779
)
778780

src/ContentProcessorWorkflow/src/libs/llm_token_telemetry.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -773,6 +773,8 @@ def emit_all(
773773
primary_model=model_deployment_name,
774774
additional_agents=additional_agents,
775775
telemetry_overhead_ms=f"{batch_overhead_ms:.3f}",
776+
agent_name=agent_name,
777+
model_deployment_name=model_deployment_name,
776778
**dimensions,
777779
)
778780

src/ContentProcessorWorkflow/src/steps/gap_analysis/executor/gap_executor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ async def handle_execute(
200200
# Track token usage for gap analysis
201201
model_name = agent_framework_helper.settings.get_service_config("default").chat_deployment_name
202202
file_names = ", ".join(f.file_name for f in processed_files) if processed_files else ""
203-
file_types = ", ".join(set(f.mime_type for f in processed_files if f.mime_type)) if processed_files else ""
203+
file_types = ", ".join(sorted(set(f.mime_type for f in processed_files if f.mime_type))) if processed_files else ""
204204
with TokenUsageScope(
205205
token_emitter,
206206
agent_name="GapAnalysis",

src/ContentProcessorWorkflow/src/steps/rai/executor/rai_executor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ async def handle_exectue(
192192
# Track token usage for RAI check
193193
model_name = agent_framework_helper.settings.get_service_config("default").chat_deployment_name
194194
file_names = ", ".join(f.file_name for f in processed_files) if processed_files else ""
195-
file_types = ", ".join(set(f.mime_type for f in processed_files if f.mime_type)) if processed_files else ""
195+
file_types = ", ".join(sorted(set(f.mime_type for f in processed_files if f.mime_type))) if processed_files else ""
196196
with TokenUsageScope(
197197
token_emitter,
198198
agent_name="RAI",

src/ContentProcessorWorkflow/src/steps/summarize/executor/summarize_executor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ async def handle_execute(
200200
# Track token usage for summarization
201201
model_name = agent_framework_helper.settings.get_service_config("default").chat_deployment_name
202202
file_names = ", ".join(f.file_name for f in processed_files) if processed_files else ""
203-
file_types = ", ".join(set(f.mime_type for f in processed_files if f.mime_type)) if processed_files else ""
203+
file_types = ", ".join(sorted(set(f.mime_type for f in processed_files if f.mime_type))) if processed_files else ""
204204
with TokenUsageScope(
205205
token_emitter,
206206
agent_name="Summarize",

0 commit comments

Comments
 (0)