Resolve CodeQL issues

Author: chaudhariniraj

src/ContentProcessor/src/libs/utils/azure_credential_utils.py

@@ -130,7 +130,11 @@ def get_azure_credential():
     logging.info(
         "[AUTH] All CLI credentials failed - falling back to DefaultAzureCredential"
     )
-    return DefaultAzureCredential()
+    raise RuntimeError(
+        "No Azure authentication available. "
+        "Use Managed Identity in Azure or run "
+        "'az login' / 'azd auth login' locally."
+    )
 
 
 def get_async_azure_credential():

src/ContentProcessor/src/libs/utils/credential_util.py

@@ -130,7 +130,11 @@ def get_azure_credential():
     logging.info(
         "[AUTH] All CLI credentials failed - falling back to DefaultAzureCredential"
     )
-    return DefaultAzureCredential()
+    raise RuntimeError(
+        "No Azure authentication available. "
+        "Use Managed Identity in Azure or run "
+        "'az login' / 'azd auth login' locally."
+    )
 
 
 def get_async_azure_credential():

src/ContentProcessorAPI/app/libs/base/application_base.py

@@ -15,7 +15,7 @@
 import os
 from abc import ABC, abstractmethod
 
-from azure.identity import DefaultAzureCredential
+from app.utils.azure_credential_utils import get_azure_credential
 from dotenv import load_dotenv
 
 from app.libs.application.application_configuration import (
@@ -72,7 +72,7 @@ def __init__(self, env_file_path: str | None = None, **data):
         self._load_env(env_file_path=env_file_path)
 
         self.application_context = AppContext()
-        self.application_context.set_credential(DefaultAzureCredential())
+        self.application_context.set_credential(get_azure_credential())
 
         app_config_endpoint: str | None = EnvConfiguration().app_config_endpoint
         if app_config_endpoint != "" and app_config_endpoint is not None:

src/ContentProcessorWorkflow/src/libs/azure/app_configuration.py

@@ -91,7 +91,13 @@ def __init__(
             ValueError: If *app_configuration_url* is ``None`` or the
                 credential is missing after defaulting.
         """
-        self.credential = credential or DefaultAzureCredential()
+        if credential is None:
+            raise ValueError(
+                "Azure credential is required. "
+                "Use Managed Identity, AzureCliCredential, or AzureDeveloperCliCredential."
+            )
+
+        self.credential = credential
         self.app_config_endpoint = app_configuration_url
         self._initialize_client()
 

src/ContentProcessorWorkflow/src/libs/base/application_base.py

@@ -36,6 +36,7 @@ def run(self):
 from abc import ABC, abstractmethod
 
 from azure.identity import DefaultAzureCredential
+from src.utils.credential_util import get_azure_credential
 from dotenv import load_dotenv
 
 from libs.agent_framework.agent_framework_settings import AgentFrameworkSettings
@@ -117,7 +118,7 @@ def __init__(self, env_file_path: str | None = None, **data):
         self._load_env(env_file_path=env_file_path)
 
         self.application_context = AppContext()
-        self.application_context.set_credential(DefaultAzureCredential())
+        self.application_context.set_credential(get_azure_credential())
 
         app_config_url: str | None = _envConfiguration().app_config_endpoint
         if app_config_url != "" and app_config_url is not None:

src/ContentProcessorWorkflow/src/utils/credential_util.py

@@ -126,7 +126,12 @@ def get_azure_credential():
     logging.info(
         "[AUTH] All CLI credentials failed - falling back to DefaultAzureCredential"
     )
-    return DefaultAzureCredential()
+    
+    raise RuntimeError(
+    "No Azure authentication available. "
+    "Use Managed Identity in Azure or run "
+    "'az login' / 'azd auth login' locally."
+    )
 
 
 def get_async_azure_credential():