refactor: move isSkillsEnabled logic to PreferencesUtils and update usages

Co-authored-by: Copilot <copilot@github.com>

Author: ethanyhou

com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/services/ChatCompletionService.java

@@ -26,7 +26,6 @@
 import org.osgi.service.event.EventHandler;
 
 import com.microsoft.copilot.eclipse.core.AuthStatusManager;
-import com.microsoft.copilot.eclipse.core.Constants;
 import com.microsoft.copilot.eclipse.core.CopilotAuthStatusListener;
 import com.microsoft.copilot.eclipse.core.CopilotCore;
 import com.microsoft.copilot.eclipse.core.FeatureFlags;
@@ -39,7 +38,7 @@
 import com.microsoft.copilot.eclipse.core.lsp.protocol.CopilotStatusResult;
 import com.microsoft.copilot.eclipse.core.lsp.protocol.TemplateSource;
 import com.microsoft.copilot.eclipse.core.utils.WorkspaceUtils;
-import com.microsoft.copilot.eclipse.ui.CopilotUi;
+import com.microsoft.copilot.eclipse.ui.utils.PreferencesUtils;
 
 /**
  * Service for handling slash commands.
@@ -110,7 +109,7 @@ private void initConversationTemplates(IProgressMonitor monitor) {
     List<ConversationTemplate> newTemplates = new ArrayList<>();
     List<ConversationAgent> newAgents = new ArrayList<>();
     Set<String> newCommands = new HashSet<>();
-    boolean skillsEnabled = isSkillsEnabled();
+    boolean skillsEnabled = PreferencesUtils.isSkillsEnabled();
 
     // Command: /***
     // Pass workspace folders so the language server returns workspace-specific
@@ -172,13 +171,6 @@ private void initConversationTemplates(IProgressMonitor monitor) {
     this.allCommands = Set.copyOf(newCommands);
   }
 
-  private boolean isSkillsEnabled() {
-    CopilotCore plugin = CopilotCore.getPlugin();
-    FeatureFlags flags = plugin != null ? plugin.getFeatureFlags() : null;
-    return CopilotUi.getPlugin().getPreferenceStore().getBoolean(Constants.ENABLE_SKILLS)
-        && flags != null && flags.isClientPreviewFeatureEnabled();
-  }
-
   /**
    * Returns templates filtered by the scope appropriate for the given chat mode. In Agent mode only {@code agent-panel}
    * scoped templates (including skills) are shown; in Ask mode only {@code chat-panel} scoped templates are shown.

com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/LanguageServerSettingManager.java

@@ -41,6 +41,7 @@
 import com.microsoft.copilot.eclipse.core.utils.WorkspaceUtils;
 import com.microsoft.copilot.eclipse.ui.CopilotUi;
 import com.microsoft.copilot.eclipse.ui.chat.services.McpExtensionPointManager;
+import com.microsoft.copilot.eclipse.ui.utils.PreferencesUtils;
 
 /**
  * A class to manage the proxy service for the Copilot Language Server.
@@ -84,7 +85,8 @@ public LanguageServerSettingManager(CopilotLanguageServerConnection conn, IProxy
     // agent related settings
     getSettings().getGithubSettings().getCopilotSettings().getAgent()
         .setAgentMaxRequests(preferenceStore.getInt(Constants.AGENT_MAX_REQUESTS));
-    getSettings().getGithubSettings().getCopilotSettings().getAgent().setEnableSkills(isSkillsEnabled());
+    getSettings().getGithubSettings().getCopilotSettings().getAgent()
+        .setEnableSkills(PreferencesUtils.isSkillsEnabled());
 
     // Set workspace context instructions when it is enabled
     if (preferenceStore.getBoolean(Constants.CUSTOM_INSTRUCTIONS_WORKSPACE_ENABLED)) {
@@ -172,7 +174,8 @@ public void propertyChange(PropertyChangeEvent event) {
         singleSetting = new CopilotLanguageServerSettings(null, null, null, settings.getGithubSettings());
         break;
       case Constants.ENABLE_SKILLS:
-        settings.getGithubSettings().getCopilotSettings().getAgent().setEnableSkills(isSkillsEnabled());
+        settings.getGithubSettings().getCopilotSettings().getAgent()
+            .setEnableSkills(PreferencesUtils.isSkillsEnabled());
         singleSetting = new CopilotLanguageServerSettings(null, null, null, settings.getGithubSettings());
         break;
       default:
@@ -522,13 +525,6 @@ public boolean isAutoShowCompletionEnabled() {
     return preferenceStore.getBoolean(Constants.AUTO_SHOW_COMPLETION);
   }
 
-  private boolean isSkillsEnabled() {
-    CopilotCore plugin = CopilotCore.getPlugin();
-    FeatureFlags flags = plugin != null ? plugin.getFeatureFlags() : null;
-    return preferenceStore.getBoolean(Constants.ENABLE_SKILLS) && flags != null
-        && flags.isClientPreviewFeatureEnabled();
-  }
-
   /**
    * Enable or disable auto show completions.
    */

com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/utils/PreferencesUtils.java

@@ -3,6 +3,10 @@
 
 package com.microsoft.copilot.eclipse.ui.utils;
 
+import com.microsoft.copilot.eclipse.core.Constants;
+import com.microsoft.copilot.eclipse.core.CopilotCore;
+import com.microsoft.copilot.eclipse.core.FeatureFlags;
+import com.microsoft.copilot.eclipse.ui.CopilotUi;
 import com.microsoft.copilot.eclipse.ui.preferences.ByokPreferencePage;
 import com.microsoft.copilot.eclipse.ui.preferences.ChatPreferencesPage;
 import com.microsoft.copilot.eclipse.ui.preferences.CompletionsPreferencesPage;
@@ -27,4 +31,17 @@ public static String[] getAllPreferenceIds() {
         McpPreferencePage.ID, ByokPreferencePage.ID };
   }
 
+  /**
+   * Returns whether the skills feature is enabled. Skills require both the user preference
+   * {@link Constants#ENABLE_SKILLS} to be set and the client preview feature flag to be enabled.
+   *
+   * @return {@code true} if skills are enabled, {@code false} otherwise
+   */
+  public static boolean isSkillsEnabled() {
+    CopilotCore plugin = CopilotCore.getPlugin();
+    FeatureFlags flags = plugin != null ? plugin.getFeatureFlags() : null;
+    return CopilotUi.getPlugin().getPreferenceStore().getBoolean(Constants.ENABLE_SKILLS)
+        && flags != null && flags.isClientPreviewFeatureEnabled();
+  }
+
 }