fix - Should not initialize empty mcp_tools_status (#1058)

Author: hithisispolarbear

com.microsoft.copilot.eclipse.ui.test/src/com/microsoft/copilot/eclipse/ui/preferences/LanguageServerSettingManagerTests.java

@@ -1,5 +1,6 @@
 package com.microsoft.copilot.eclipse.ui.preferences;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNull;
@@ -216,4 +217,22 @@ void testUpdateStrictSslSetting() {
     assertFalse(capturedSettings.getHttp().isProxyStrictSsl());
   }
 
+  @Test
+	void testInitializeMcpToolsStatusWhenEmpty() {
+    // arrange
+	when(mockPreferenceStore.getBoolean(Constants.AUTO_SHOW_COMPLETION)).thenReturn(true);
+	when(mockPreferenceStore.getString(Constants.PROXY_KERBEROS_SP)).thenReturn(null);
+	when(mockPreferenceStore.getString(Constants.GITHUB_ENTERPRISE)).thenReturn(null);
+	when(mockPreferenceStore.getString(Constants.MCP)).thenReturn(null);
+    when(mockPreferenceStore.getString(Constants.MCP_TOOLS_STATUS)).thenReturn("");
+
+    // act
+    LanguageServerSettingManager manager = new LanguageServerSettingManager(mockLsConnection, mockProxyService,
+        mockPreferenceStore);
+	assertDoesNotThrow(manager::initializeMcpToolsStatus);
+
+    // assert
+	verify(mockPreferenceStore, times(1)).getString(Constants.MCP_TOOLS_STATUS);
+    verify(mockLsConnection, times(0)).updateMcpToolsStatus(any());
+  }
 }

com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/CopilotPreferenceInitializer.java

@@ -43,7 +43,7 @@ public void initializeDefaultPreferences() {
           }
         }
          """);
-    pref.setDefault(Constants.MCP_TOOLS_STATUS, "");
+    pref.setDefault(Constants.MCP_TOOLS_STATUS, "{}");
     pref.setDefault(Constants.QUICK_START_VERSION, 0);
   }
 }

com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/preferences/LanguageServerSettingManager.java

@@ -7,6 +7,7 @@
 
 import com.google.gson.Gson;
 import com.google.gson.reflect.TypeToken;
+import org.apache.commons.lang3.StringUtils;
 import org.eclipse.core.net.proxy.IProxyChangeEvent;
 import org.eclipse.core.net.proxy.IProxyChangeListener;
 import org.eclipse.core.net.proxy.IProxyData;
@@ -179,6 +180,10 @@ public void initializeMcpToolsStatus() {
    *        {"server1":{"tool1":true,"tool2":false},"server2":{"tool1":true}}
    */
   private void updateMcpToolsStatus(String mcpToolsStatus) {
+    if (StringUtils.isBlank(mcpToolsStatus)) {
+      return;
+    }
+
     try {
       Gson gson = new Gson();
       Map<String, Map<String, Boolean>> toolStatusMap = gson.fromJson(mcpToolsStatus,