feat: [TBB] extract SpinnerAnimator for loading animations in AgentStatusLabel (Thinking Part1)#146
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts the spinner animation logic into a reusable SpinnerAnimator utility, and updates AgentStatusLabel to use it—preparing the chat UI to reuse the same loading spinner for upcoming “thinking” states.
Changes:
- Added
SpinnerAnimatorto encapsulate SWT timer-driven frame animation and per-frameImagedisposal. - Refactored
AgentStatusLabelto delegate spinner start/stop toSpinnerAnimator, removing inline animation logic. - Tweaked
AgentStatusLabellayout margins to reduce default padding.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/swt/SpinnerAnimator.java |
New reusable spinner animation helper that updates a Label and manages frame image lifecycle. |
com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/AgentStatusLabel.java |
Replaces local spinner animation implementation with SpinnerAnimator usage. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ethanyhou
changed the title
ethanyhou
changed the title
jdneo
approved these changes
May 8, 2026
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a prerequisite to enable thinking in chat view as the thinking status also needs a spinner. Extract a SpinnerAnimator to reuse.