Skip to content

fix - UI freeze caused by deadlock in EditorsManager #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdneo merged 1 commit into from
May 13, 2026
Merged

fix - UI freeze caused by deadlock in EditorsManager #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ...ft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/completion/EditorsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,21 @@ public RenderManager getOrCreateNesRenderManager(ITextEditor editor) {
return null;
}

return nesRenderManagers.computeIfAbsent(editor,
ed -> new RenderManager(this.languageServer, this.nesProvider, ed));
// Avoid computeIfAbsent() here: the RenderManager constructor calls
// Display.syncExec() via registerListeners(), and computeIfAbsent() holds
// an internal bucket lock during the mapping function. If the UI thread
// concurrently calls remove() on the same bucket, both threads deadlock.
// See https://github.com/microsoft/copilot-for-eclipse/issues/175
RenderManager mgr = nesRenderManagers.get(editor);
if (mgr == null) {
mgr = new RenderManager(this.languageServer, this.nesProvider, editor);
RenderManager existing = nesRenderManagers.putIfAbsent(editor, mgr);
if (existing != null) {
Comment thread
xinyi-gong marked this conversation as resolved.
mgr.dispose();
mgr = existing;
}
}
return mgr;
}

/**
Expand Down
Loading