fix - file and directory link navigation in chat tool results#272
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes chat tool result link navigation by improving how file and directory hyperlinks are resolved and opened in the Eclipse UI, especially for local filesystem paths outside the workspace.
Changes:
- Centralizes local filesystem path/
file:URI parsing incoreviaFileUtils.getLocalFilePath(...)and updates file tools to use it. - Updates chat hyperlink opening to:
- open local files outside the workspace in an editor, and
- reveal workspace folders/projects in Project Explorer (instead of delegating to the browser).
- Extends SWTBot test plan documentation with a new test case covering local file link navigation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/tools/FileToolBase.java | Removes duplicated local-path parsing helper (now centralized in core). |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/tools/EditFileTool.java | Switches to FileUtils.getLocalFilePath(...) for local edits. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/tools/CreateFileTool.java | Switches to FileUtils.getLocalFilePath(...) for local creates. |
| com.microsoft.copilot.eclipse.ui/src/com/microsoft/copilot/eclipse/ui/chat/FileAnnotationHyperlinkDetector.java | Adds folder/project reveal + local-file editor fallback for file: links. |
| com.microsoft.copilot.eclipse.swtbot.test/test-plans/file-system/local-file-edit-and-create-tools.md | Adds a test plan section for navigating to local files from tool links. |
| com.microsoft.copilot.eclipse.core/src/com/microsoft/copilot/eclipse/core/utils/FileUtils.java | Adds getLocalFilePath(...) and fragment stripping to support consistent parsing. |
jdneo
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #262
Problem
Clicking file path links in Chat tool results fails to open files that are outside the Eclipse workspace. Directory links in the workspace also had no meaningful behavior.
Changes