Commit b0b77ba
Fix two Copilot review nits
1) ActivityUnversionedFallback XML doc previously claimed MatchStrategy
does not gate activity dispatch. That's incorrect: GrpcDurableTaskWorker's
OnRunActivityAsync calls EvaluateOrchestrationVersioning against the
activity work item's version (set via TaskOptions.Version at schedule
time, or inherited from the calling orchestration when null), and the
strict-mode work-item filter narrows activity filters too. Rewrote the
interaction bullet to match actual behavior.
2) UnversionedFallbackSample/Program.cs had a comment saying orchestrator
fallback was 'commented below' while the next line actively enabled it.
Rewrote the comment to match what the sample actually does: both flags
are enabled to demonstrate orchestrator catch-all dispatch; the advice
to start with activity-only stays as guidance for the reader's own code.
Addresses Copilot review feedback at #discussion_r3305294155 and #discussion_r3305294212.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent e01fa18 commit b0b77ba
2 files changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
32 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
367 | | - | |
368 | | - | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
369 | 373 | | |
370 | 374 | | |
371 | 375 | | |
| |||
0 commit comments