-
Notifications
You must be signed in to change notification settings - Fork 15
Introduce versioning into the Java SDK #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcWorkerVersioningOptions.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| package com.microsoft.durabletask; | ||
|
|
||
| /** | ||
| * Options for configuring versioning behavior in the DurableTaskGrpcWorker. | ||
| */ | ||
| public final class DurableTaskGrpcWorkerVersioningOptions { | ||
|
|
||
| /** | ||
| * Strategy for matching versions. | ||
| * NONE: No version matching is performed. | ||
| * STRICT: The version must match exactly. | ||
| * CURRENTOROLDER: The version must be the current version or older. | ||
| */ | ||
| public enum VersionMatchStrategy { | ||
| NONE, | ||
| STRICT, | ||
| CURRENTOROLDER; | ||
| } | ||
|
|
||
| /** | ||
| * Strategy for handling version mismatches. | ||
| * REJECT: Reject the orchestration if the version does not match. The orchestration will be retried later. | ||
| * FAIL: Fail the orchestration if the version does not match. | ||
| */ | ||
| public enum VersionFailureStrategy { | ||
| REJECT, | ||
| FAIL; | ||
| } | ||
|
|
||
| private final String version; | ||
| private final String defaultVersion; | ||
| private final VersionMatchStrategy matchStrategy; | ||
| private final VersionFailureStrategy failureStrategy; | ||
|
|
||
| /** | ||
| * Constructor for DurableTaskGrpcWorkerVersioningOptions. | ||
| * @param version the version that is matched against orchestrations | ||
| * @param defaultVersion the default version used when starting sub orchestrations from this worker | ||
| * @param matchStrategy the strategy for matching versions | ||
| * @param failureStrategy the strategy for handling version mismatches | ||
| */ | ||
| public DurableTaskGrpcWorkerVersioningOptions(String version, String defaultVersion, VersionMatchStrategy matchStrategy, VersionFailureStrategy failureStrategy) { | ||
| this.version = version; | ||
| this.defaultVersion = defaultVersion; | ||
| this.matchStrategy = matchStrategy; | ||
| this.failureStrategy = failureStrategy; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the version that is matched against orchestrations. | ||
| * @return the version that is matched against orchestrations | ||
| */ | ||
| public String getVersion() { | ||
| return version; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the default version used when starting sub orchestrations from this worker. | ||
| * @return the default version used when starting sub orchestrations from this worker | ||
| */ | ||
| public String getDefaultVersion() { | ||
| return defaultVersion; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the strategy for matching versions. | ||
| * @return the strategy for matching versions | ||
| */ | ||
| public VersionMatchStrategy getMatchStrategy() { | ||
| return matchStrategy; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the strategy for handling version mismatches. | ||
| * @return the strategy for handling version mismatches | ||
| */ | ||
| public VersionFailureStrategy getFailureStrategy() { | ||
| return failureStrategy; | ||
| } | ||
| } |
62 changes: 62 additions & 0 deletions
62
client/src/main/java/com/microsoft/durabletask/NewSubOrchestrationInstanceOptions.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| package com.microsoft.durabletask; | ||
|
|
||
| /** | ||
| * Options for starting a new sub-orchestration instance. | ||
| */ | ||
| public class NewSubOrchestrationInstanceOptions extends TaskOptions { | ||
|
|
||
| private String instanceId; | ||
| private String version; | ||
|
|
||
| /** | ||
| * Creates options with a retry policy for the sub-orchestration. | ||
| * @param retryPolicy The retry policy to use for the sub-orchestration. | ||
| */ | ||
| public NewSubOrchestrationInstanceOptions(RetryPolicy retryPolicy) { | ||
| super(retryPolicy); | ||
| } | ||
|
|
||
| /** | ||
| * Creates options with a retry handler for the sub-orchestration. | ||
| * @param retryHandler The retry handler to use for the sub-orchestration. | ||
| */ | ||
| public NewSubOrchestrationInstanceOptions(RetryHandler retryHandler) { | ||
| super(retryHandler); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the version for the sub-orchestration instance. | ||
| * @param version The version string to use. | ||
| * @return This options object for chaining. | ||
| */ | ||
| public NewSubOrchestrationInstanceOptions setVersion(String version) { | ||
| this.version = version; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the version for the sub-orchestration instance. | ||
| * @return The version string, or null if not set. | ||
| */ | ||
| public String getVersion() { | ||
| return version; | ||
| } | ||
|
|
||
| /** | ||
| * Sets a custom instance ID for the sub-orchestration. | ||
| * @param instanceId The custom instance ID to use. | ||
| * @return This options object for chaining. | ||
| */ | ||
| public NewSubOrchestrationInstanceOptions setInstanceId(String instanceId) { | ||
| this.instanceId = instanceId; | ||
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the custom instance ID for the sub-orchestration. | ||
| * @return The instance ID, or null if not set. | ||
| */ | ||
| public String getInstanceId() { | ||
| return instanceId; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.